Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump mkdocs-material #1789

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

adriencaccia
Copy link
Contributor

Following #1760, highlighted code color in the dark theme was nearly impossible to read, as @anglid stated in #725.

Later in that issue, @squidfunk stated that by bumping mkdocs-material to 5.5.0, the colors will be better.

  • Light theme before:
    image

  • Light theme now:
    image

  • Dark theme before:
    image

  • Dark theme now:
    image

@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #1789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1789   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          235       235           
  Lines         6989      6989           
=========================================
  Hits          6989      6989           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63b1ef...084f47e. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 084f47e at: https://5f1c219b757708e92a319bdf--fastapi.netlify.app

@tiangolo tiangolo merged commit 6d7c989 into fastapi:master Aug 3, 2020
@tiangolo
Copy link
Member

tiangolo commented Aug 3, 2020

Great, thanks for your contribution! And thanks for taking the time to take the screenshots 🚀 🎨

@adriencaccia adriencaccia deleted the bump-mkdocs-material branch December 6, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants