Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pencil2: Fix awkward pronoun usage #1824

Merged
merged 3 commits into from Aug 9, 2020

Conversation

Mause
Copy link
Contributor

@Mause Mause commented Aug 2, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #1824 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1824    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          235       239     +4     
  Lines         6831      7124   +293     
==========================================
+ Hits          6831      7124   +293     
Impacted Files Coverage Δ
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
tests/test_path.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
tests/test_query.py 100.00% <0.00%> (ø)
fastapi/exceptions.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
tests/test_fakeasync.py 100.00% <0.00%> (ø)
fastapi/security/http.py 100.00% <0.00%> (ø)
tests/test_application.py 100.00% <0.00%> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc494e3...652c655. Read the comment docs.

@Mause Mause marked this pull request as ready for review August 2, 2020 11:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2020

📝 Docs preview for commit 976d35f at: https://5f26add9ff928d3432cb9603--fastapi.netlify.app

Copy link
Sponsor Collaborator

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2020

📝 Docs preview for commit 505c480 at: https://5f27d491ff928debb1cb91ae--fastapi.netlify.app

@acnebs
Copy link

acnebs commented Aug 7, 2020

A number of these are talking about "the client". Is that not more of an "it"?

@tiangolo
Copy link
Owner

tiangolo commented Aug 9, 2020

Thanks a lot! 🔍 📝

I want to have a welcoming space in the FastAPI community and I don't want to have language that might feel unwelcoming. 🚀

At the same time, one of my main objectives in the docs is to reduce ambiguity to make it as easy to learn and understand as possible, even for people that might not be native English speakers (like myself), so I updated those examples a bit to make them non-gender specific without having to deal with the ambiguity of possible plurals.

@tiangolo tiangolo merged commit 0a2fc78 into tiangolo:master Aug 9, 2020
@tiangolo tiangolo changed the title ✏️ Fix awkward pronoun usage pencil2: Fix awkward pronoun usage Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants