📝 Add note in CORS tutorial about allow_origins with ["*"] and allow_credentials #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couldn't get credentials working with `allow_origins` set to `['*']`. Thought this might help others.
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 7079 7079
=========================================
Hits 7079 7079 Continue to review full report at Codecov.
|
|
📝 Docs preview for commit b97e74a at: https://5f372bf88c1beb3361110039--fastapi.netlify.app |
Kludex
approved these changes
Aug 15, 2020
tiangolo
changed the title
tiangolo
changed the title
|
Good point! Thanks for the contribution @dsmurrell ! 🚀 🍰 And thanks @Kludex for the review ☕ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't get credentials working with
allow_originsset to['*']. Thought this might help others.I was lucky to find this after a while: https://stackoverflow.com/questions/46288437/set-cookies-for-cross-origin-requests
which explains: "Also, make sure the HTTP header Access-Control-Allow-Origin is set and not with a wildcard *."
Specifying some origins, allows my axios request with
{ withCredentials: true }set to work.