Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for docs/ja/docs/tutorial/body-multiple-params.md #1903

Merged
merged 21 commits into from Jan 15, 2024
Merged

🌐 Add Japanese translation for docs/ja/docs/tutorial/body-multiple-params.md #1903

merged 21 commits into from Jan 15, 2024

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 16, 2020 •
edited

This PR translates the tutorial/body-multiple-params.md to Japanese.
Please review tutorial/body-multiple-params.md

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 16, 2020
Closed
@codecov
Copy link

codecov bot commented Aug 16, 2020 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (c7fb102) 100.00%.

❗ Current head c7fb102 differs from pull request most recent head 950acbc. Consider uploading reports for the commit 950acbc to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #1903     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit aa26882 at: https://5f39142ec3f45f531ee0db3c--fastapi.netlify.app

@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for your reveiw!
I didn't know the reference had changed at any time.

@github-actions
Copy link
Contributor

📝 Docs preview for commit da043bf at: https://5f3ea0b8f7b63fdddc4d58e0--fastapi.netlify.app

tokusumi
tokusumi suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had overlooked similar corrections

docs/ja/docs/tutorial/body-multiple-params.md Outdated

しかし、`item`と`user`のように複数のボディパラメータを宣言することもできます:

```Python hl_lines="20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="22"

docs/ja/docs/tutorial/body-multiple-params.md Outdated

また、デフォルトの`None`を設定することで、ボディパラメータをオプションとして宣言することもできます:

```Python hl_lines="17 18 19"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="19 20 21"

docs/ja/docs/tutorial/body-multiple-params.md Outdated
しかし、`Body`を使用して、**FastAPI** に別のボディキーとして扱うように指示することができます:


```Python hl_lines="21"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="23"

docs/ja/docs/tutorial/body-multiple-params.md Outdated

以下において:

```Python hl_lines="25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="27"

@SwftAlpc
Copy link
Contributor Author

@tokusumi
Could you confirm that it has been corrected?

@github-actions
Copy link
Contributor

📝 Docs preview for commit 91d2b33 at: https://5f422586c86c10375bdfae6e--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit e53362e at: https://5f4cbfe5302549facd748a70--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit c7fb102 at: https://5f9a9f3979314833e7141a15--fastapi.netlify.app

@tiangolo tiangolo changed the title Add tutorial/body-multiple-params.md 🌐 Add Japanese translation for docs/ja/docs/tutorial/body-multiple-params.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 950acbc at: https://6499c133706d0c007b5a1665--fastapi.netlify.app

@alejsdev
Copy link
Collaborator

Thanks for your help @SwftAlpc and @tokusumi for the review 🤓💯

@alejsdev alejsdev merged commit a14907a into tiangolo:master Jan 15, 2024
34 checks passed
@tiangolo tiangolo mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokusumi tokusumi tokusumi approved these changes

Assignees
No one assigned
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SwftAlpc @tiangolo @alejsdev @tokusumi @ryuckel