Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese tranlsation for docs/ja/docs/tutorial/schema-extra-example.md #1931

Merged
merged 20 commits into from
Jan 15, 2024
Merged

🌐 Add Japanese tranlsation for docs/ja/docs/tutorial/schema-extra-example.md #1931

merged 20 commits into from
Jan 15, 2024

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 20, 2020 •
edited
Loading

This PR translates the tutorial/schema-extra-example.md to Japanese.
Please review tutorial/schema-extra-example.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 20, 2020
Closed
@codecov
Copy link

codecov bot commented Aug 20, 2020 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (0259b1b) 100.00%.

❗ Current head 0259b1b differs from pull request most recent head b7379a6. Consider uploading reports for the commit b7379a6 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #1931     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 92d28ac at: https://5f3ea0bac0f1baeb4f2b2662--fastapi.netlify.app

tokusumi
tokusumi suggested changes Aug 21, 2020
View reviewed changes
docs/ja/docs/tutorial/schema-extra-example.md Outdated

<a href="https://pydantic-docs.helpmanual.io/usage/schema/#schema-customization" class="external-link" target="_blank">Pydanticのドキュメント: スキーマのカスタマイズ</a>で説明されているように、`Config`と`schema_extra`を使ってPydanticモデルの例を宣言することができます:

```Python hl_lines="13 14 15 16 17 18 19 20 21"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="15 16 17 18 19 20 21 22 23"

docs/ja/docs/tutorial/schema-extra-example.md Outdated

後述する`Field`、`Path`、`Query`、`Body`などでは、任意の引数を関数に渡すことでJSON Schemaの追加情報を宣言することもできます:

```Python hl_lines="2 8 9 10 11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="4 10 11 12 13"

docs/ja/docs/tutorial/schema-extra-example.md Outdated

例えば、`Body`にボディリクエストの`example`を渡すことができます:

```Python hl_lines="19 20 21 22 23 24"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="21 22 23 24 25 26"

@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for review! I fixed it.
Please re-review.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 425e9c0 at: https://5f41609c618e31e4b8a4bf10--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit b62534b at: https://5f4cbf9c83248de318f6ba59--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0259b1b at: https://5f9aa3a15a2a0541ef714858--fastapi.netlify.app

@tiangolo tiangolo changed the title Add tutorial/schema-extra-example.md. Japanese ver. 🌐 Add Japanese tranlsation for docs/ja/docs/tutorial/schema-extra-example.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit b7379a6 at: https://6499c2228f963500a17ce1a3--fastapi.netlify.app

@tiangolo
Copy link
Member

As this was done by @SwftAlpc and reviewed by @tokusumi, champions of the Japanese translations, I'm gonna merge this. 🚀

@tiangolo tiangolo merged commit 2619bbd into fastapi:master Jan 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokusumi tokusumi tokusumi approved these changes

Assignees
No one assigned
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SwftAlpc @tiangolo @tokusumi @ryuckel