New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ Add Japanese translation for docs/ja/docs/tutorial/response-status-code.md
#1942
๐ Add Japanese translation for docs/ja/docs/tutorial/response-status-code.md
#1942
Conversation
โฆ/ryuckel/fastapi into feature/add-japanese-translation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 540 239 -301
Lines 13969 7079 -6890
===========================================
- Hits 13969 7079 -6890 โ View full report in Codecov by Sentry. |
๐ Docs preview for commit 22f8861 at: https://5f3ff22c5c652e24b3592495--fastapi.netlify.app |
๐ Docs preview for commit 31a534e at: https://5f4cbf4e5bf93092ddad3227--fastapi.netlify.app |
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
โฆhub.com:SwftAlpc/fastapi into translation/ja-tutorial-response-status-code-md
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@tokusumi |
๐ Docs preview for commit 2e95898 at: https://5f9aab908b8d8321f2fcef08--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for accepting my suggestions๐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks mostly good.
I pointed out some details.
* `@app.post()` | ||
* `@app.put()` | ||
* `@app.delete()` | ||
* ใชใฉใ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it's a little unnatural for translating "etc" to "ใชใฉ" and I think it may be kept an English word "etc".
|
||
ใคใพใ: | ||
|
||
* `100`ไปฅไธใฏใๆ ๅ ฑใใฎใใใฎใใฎใงใใใ็ดๆฅไฝฟใใใจใฏใปใจใใฉใใใพใใใใใใใฎในใใผใฟในใณใผใใๆใคใฌในใใณในใฏใใใฃใๆใคใใจใใงใใพใใใ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a "ใ" is duplicated.
{!../../../docs_src/response_status_code/tutorial002.py!} | ||
``` | ||
|
||
ใใใใฏไพฟๅฉใงใใใใใใฏๅใ็ชๅทใไฟๆใใฆใใใใใฎๆนๆณใงใฏใจใใฃใฟใฎ่ชๅ่ฃๅฎใไฝฟ็จใใฆใใใใ่ฆใคใใใใจใใงใใพใใ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It's better to modify "ไฟๆใใฆใใ" to "ไฟๆใใฆใใพใใ" because "but" is used as a conjunction in the original sentence.
- In my opinion, It's better to modify the first "ใใใ" to "
fastapi.status
ใฎๅคๆฐ" and "ใใฎๆนๆณ" to "`ใใใใฎๅคๆฐใไฝฟ็จใใๆนๆณ" because "ใใ" or "ใใฎ" appears three times make the sentence a little difficult to read.
docs/ja/docs/tutorial/response-status-code.md
๐ Docs preview for commit afa65b7 at: https://6499caf4706d0c04fc5a1966--fastapi.netlify.app |
This PR translates the tutorial/response-status-code.md to Japanese.
Please review tutorial/response-status-code.md.
Issue #1571 generates a new directory to support Japanese.PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.