Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŒ Add Japanese translation for docs/ja/docs/tutorial/response-status-code.md #1942

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 21, 2020

This PR translates the tutorial/response-status-code.md to Japanese.
Please review tutorial/response-status-code.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (2e95898) 100.00%.

โ— Current head 2e95898 differs from pull request most recent head afa65b7. Consider uploading reports for the commit afa65b7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1942     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890     

see 356 files with indirect coverage changes

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

๐Ÿ“ Docs preview for commit 22f8861 at: https://5f3ff22c5c652e24b3592495--fastapi.netlify.app

docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/response-status-code.md Outdated Show resolved Hide resolved
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

๐Ÿ“ Docs preview for commit 31a534e at: https://5f4cbf4e5bf93092ddad3227--fastapi.netlify.app

SwftAlpc and others added 5 commits October 29, 2020 20:39
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
SwftAlpc and others added 7 commits October 29, 2020 20:41
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
โ€ฆhub.com:SwftAlpc/fastapi into translation/ja-tutorial-response-status-code-md
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for the review!
May I ask for a second review and approval?

@github-actions
Copy link
Contributor

๐Ÿ“ Docs preview for commit 2e95898 at: https://5f9aab908b8d8321f2fcef08--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for accepting my suggestions๐ŸŽ‰

Copy link

@delhi09 delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly good.
I pointed out some details.

* `@app.post()`
* `@app.put()`
* `@app.delete()`
* ใชใฉใ€‚
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it's a little unnatural for translating "etc" to "ใชใฉ" and I think it may be kept an English word "etc".


ใคใพใ‚Š:

* `100`ไปฅไธŠใฏใ€Œๆƒ…ๅ ฑใ€ใฎใŸใ‚ใฎใ‚‚ใฎใงใ™ใ€‚ใ€‚็›ดๆŽฅไฝฟใ†ใ“ใจใฏใปใจใ‚“ใฉใ‚ใ‚Šใพใ›ใ‚“ใ€‚ใ“ใ‚Œใ‚‰ใฎใ‚นใƒ†ใƒผใ‚ฟใ‚นใ‚ณใƒผใƒ‰ใ‚’ๆŒใคใƒฌใ‚นใƒใƒณใ‚นใฏใƒœใƒ‡ใ‚ฃใ‚’ๆŒใคใ“ใจใŒใงใใพใ›ใ‚“ใ€‚
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a "ใ€‚" is duplicated.

{!../../../docs_src/response_status_code/tutorial002.py!}
```

ใใ‚Œใ‚‰ใฏไพฟๅˆฉใงใ™ใ€‚ใใ‚Œใ‚‰ใฏๅŒใ˜็•ชๅทใ‚’ไฟๆŒใ—ใฆใŠใ‚Šใ€ใใฎๆ–นๆณ•ใงใฏใ‚จใƒ‡ใ‚ฃใ‚ฟใฎ่‡ชๅ‹•่ฃœๅฎŒใ‚’ไฝฟ็”จใ—ใฆใใ‚Œใ‚‰ใ‚’่ฆ‹ใคใ‘ใ‚‹ใ“ใจใŒใงใใพใ™ใ€‚
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It's better to modify "ไฟๆŒใ—ใฆใŠใ‚Š" to "ไฟๆŒใ—ใฆใ„ใพใ™ใŒ" because "but" is used as a conjunction in the original sentence.
  • In my opinion, It's better to modify the first "ใใ‚Œใ‚‰" to "fastapi.statusใฎๅค‰ๆ•ฐ" and "ใใฎๆ–นๆณ•" to "`ใใ‚Œใ‚‰ใฎๅค‰ๆ•ฐใ‚’ไฝฟ็”จใ™ใ‚‹ๆ–นๆณ•" because "ใใ‚Œ" or "ใใฎ" appears three times make the sentence a little difficult to read.

@tiangolo tiangolo changed the title Add tutorial/response-status-code.md Japanese ver. ๐ŸŒ Add Japanese translation for docs/ja/docs/tutorial/response-status-code.md Jun 26, 2023
@tiangolo
Copy link
Owner

๐Ÿ“ Docs preview for commit afa65b7 at: https://6499caf4706d0c04fc5a1966--fastapi.netlify.app

@alejsdev
Copy link
Collaborator

Thanks @SwftAlpc ๐Ÿค“

And thanks for reviewing @tokusumi ๐Ÿ”

@alejsdev alejsdev merged commit 88225ae into tiangolo:master Jan 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants