Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/tutorial/handling-errors.md #1953

Merged

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 23, 2020

This PR translates the tutorial/handling-errors.md to Japanese.
Please review tutorial/handling-errors.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (afaf616) 100.00%.

❗ Current head afaf616 differs from pull request most recent head e3f638b. Consider uploading reports for the commit e3f638b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1953     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890     

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 6716aa5 at: https://5f42329b442f8e770ec9c7df--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typo and unnecessary symbol

{!../../../docs_src/handling_errors/tutorial001.py!}
```

### 結果のレスポンス
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レスポンス結果

docs/ja/docs/tutorial/handling-errors.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/handling-errors.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/handling-errors.md Outdated Show resolved Hide resolved
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit 61fc57d at: https://5f4cbfe6281ab685a75f5ecc--fastapi.netlify.app

SwftAlpc and others added 5 commits October 30, 2020 00:22
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
…om:SwftAlpc/fastapi into translation/ja-tutorial-handling-errors-md
@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for the review!
Cloud you check it out?

@github-actions
Copy link
Contributor

📝 Docs preview for commit afaf616 at: https://5f9ae0261c44a8090023d396--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your work is awesome. Thank you.

@tiangolo tiangolo changed the title Add tutorial/handling-errors.md Japanese ver. 🌐 Add Japanese translation for docs/ja/docs/tutorial/handling-errors.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit e3f638b at: https://6499c40866a23b009bfcc170--fastapi.netlify.app

@alejsdev
Copy link
Collaborator

Thanks for your help! @SwftAlpc 😸

And thanks for reviewing @tokusumi 🔍🧐

@alejsdev alejsdev merged commit 217bff2 into tiangolo:master Jan 15, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants