Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/tutorial/path-operation-configuration.md #1954

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 23, 2020

This PR translates the tutorial/path-operation-configuration.md to Japanese.
Please review tutorial/path-operation-configuration.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf73051) to head (b193d88).
Report is 1672 commits behind head on master.

❗ Current head b193d88 differs from pull request most recent head efcd91f. Consider uploading reports for the commit efcd91f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1954     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 95dbb80 at: https://5f4240d89b90391669d19890--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved this.
I only have some proposal (no request change). please refer if you find better translation.

@@ -0,0 +1,97 @@
# Path Operationの設定

*path operationデコレータ*を設定するために渡すことができるパラメータがいくつかあります。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path operationデコレータの設定のためにいくつかのパラメータがあります。
(日本語としてはほんの少しまわりくどく感じました)


## docstringを用いた説明

説明文は長くて複数行におよぶ傾向があるので、関数<abbr title="ドキュメントに使用される関数内の最初の式(変数に代入されていない)としての複数行の文字列">docstring</abbr>で*path operation*の説明文を宣言すると、**FastAPI** はそれを読み取ることができます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

説明文は長くて複数行におよぶ傾向があるので、関数docstring内にpath operationの説明文を宣言できます。すると、FastAPI は説明文を読み込んでくれます。

{!../../../docs_src/path_operation_configuration/tutorial004.py!}
```

それは対話的ドキュメントで使用されます:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは


<img src="https://fastapi.tiangolo.com/img/tutorial/path-operation-configuration/image03.png">

## *path operation* の非推奨
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非推奨のpath operation


<img src="https://fastapi.tiangolo.com/img/tutorial/path-operation-configuration/image04.png">

非推奨である場合とそうでない場合の*path operations*がどのように見えるかを確認してください:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path operationsが非推奨である場合とそうでない場合でどのように見えるかを確認してください:

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit 563b11b at: https://5f4cbf4f15bbe4a60b9c8d93--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit f532e13 at: https://5f9ae0e1df0a3a0a3cf71570--fastapi.netlify.app

@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for the reveiw!
I fixed some translations.
Please confirm them.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 48ffbbb at: https://5f9ae1d51c44a80d1323d3d8--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I found something left uncorrected.

docs/ja/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
SwftAlpc and others added 5 commits October 30, 2020 01:23
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit b193d88 at: https://5f9aed9b26b61b13d2b0235a--fastapi.netlify.app

@tiangolo tiangolo changed the title Add tutorial/path-operation-configuration.md Japanese ver. 🌐 Add Japanese translation for docs/ja/docs/tutorial/path-operation-configuration.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 99ca293 at: https://6499c6203df37400be860887--fastapi.netlify.app

@tiangolo
Copy link
Owner

tiangolo commented Apr 2, 2024

It seems like the changes requested by @tokusumi are handled, and as @SwftAlpc is one of the champions of the Japanese translations, I'll go ahead and merge this. 🚀

@tiangolo tiangolo enabled auto-merge (squash) April 2, 2024 04:32
@tiangolo tiangolo merged commit 31dabcb into tiangolo:master Apr 2, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants