Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/dependencies-with-yield.md #1961

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 23, 2020

This PR translates the tutorial/dependencies/dependencies-with-yield.md to Japanese.
Please review tutorial/dependencies/dependencies-with-yield.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.

PR #1957 generates a new directory for dependencies in tutorial.
I will fix dependency after #1571, #1656 and #1957 are merged.

@SwftAlpc SwftAlpc changed the title Add tutorial/dependencies/dependencies-with-yield.md Add tutorial/dependencies/dependencies-with-yield.md Japanese ver Aug 23, 2020
@SwftAlpc SwftAlpc mentioned this pull request Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (767f9ed) 100.00%.
Report is 1066 commits behind head on master.

❗ Current head 767f9ed differs from pull request most recent head 0964d27. Consider uploading reports for the commit 0964d27 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1961     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9dc62f2 at: https://5f42952b848e3d80d81f334b--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
SwftAlpc and others added 3 commits October 30, 2020 01:08
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for your review!
I adopt your suggetions.
Please check it out!

@github-actions
Copy link
Contributor

📝 Docs preview for commit 767f9ed at: https://5f9ae9d8be43fd0c7a609acd--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cooperating for improvement.

Copy link
Contributor

@sh0nk sh0nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix only the typos?


**FastAPI** は、`yield`を持つ各依存関係の「終了コード」が正しい順番で実行されていることを確認します。

例えば、`dependency_c`は`dependency_b`と`dependency_b`に依存する`dependency_a`に、依存することができます:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
例えば、`dependency_c``dependency_b``dependency_b`に依存する`dependency_a`に、依存することができます:
例えば、`dependency_c``dependency_b``dependency_a`に依存する`dependency_b`に依存することができます:

typo?


`yield`と例外をキャッチする`try`ブロックを持つことができる依存関係を使用することができることがわかりました。

`yield`の後の終了コードで`HTTPException`などを発生させたくなるかもしれません。しかし**それはうまくいきません**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`yield`の後の終了コードで`HTTPException`などを発生させたくなるかもしれません。しかし**それはうまくいきません**
`yield`の後の終了コードで`HTTPException`などを発生させたくなるかもしれません。しかし**それはうまくいきません**

Add a trailing period.


`yield`を持つ依存関係の終了コードは[例外ハンドラ](../handling-errors.md#install-custom-exception-handlers){.internal-link target=_blank}の*後に*実行されます。依存関係によって投げられた例外を終了コード(`yield`の後)でキャッチするものはなにもありません。

つまり、`yield`の後に`HTTPException`を発生させた場合、`HTTTPException`をキャッチしてHTTP 400のレスポンスを返すデフォルトの(あるいは任意のカスタムの)例外ハンドラは、その例外をキャッチすることができなくなります。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
つまり、`yield`の後に`HTTPException`を発生させた場合、`HTTTPException`をキャッチしてHTTP 400のレスポンスを返すデフォルトの(あるいは任意のカスタムの)例外ハンドラは、その例外をキャッチすることができなくなります。
つまり、`yield`の後に`HTTPException`を発生させた場合、`HTTPException `をキャッチしてHTTP 400のレスポンスを返すデフォルトの(あるいは任意のカスタムの)例外ハンドラは、その例外をキャッチすることができなくなります。

typo

@tiangolo tiangolo changed the title Add tutorial/dependencies/dependencies-with-yield.md Japanese ver 🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/index.md and docs/ja/docs/tutorial/dependencies/dependencies-with-yield.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 1cfe4ba at: https://6499cbcd89d3ab061a01d4fc--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/index.md and docs/ja/docs/tutorial/dependencies/dependencies-with-yield.md 🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/dependencies-with-yield.md Jan 15, 2024
@tiangolo
Copy link
Owner

As this was done by @SwftAlpc and approved by @tokusumi, champions of the Japanese translations, I'll merge this right away. 🚀 Thanks! 🍪

@tiangolo tiangolo enabled auto-merge (squash) January 15, 2024 16:28
@tiangolo tiangolo merged commit 7b462b2 into tiangolo:master Jan 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants