Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for Benchmarks #1992

Merged
merged 7 commits into from
Oct 17, 2020
Merged

🌐 Add Japanese translation for Benchmarks #1992

merged 7 commits into from
Oct 17, 2020

Conversation

komtaki
Copy link
Contributor

@komtaki komtaki commented Aug 31, 2020 •
edited
Loading

This PR translates the benchmarks.md to Japanese.

According to the issue: #1572

Thanks!!

@codecov
Copy link

codecov bot commented Aug 31, 2020 •
edited
Loading

Codecov Report

Merging #1992 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1992   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ee4d9...64b2b3d. Read the comment docs.

@komtaki komtaki marked this pull request as ready for review August 31, 2020 13:44
@komtaki komtaki mentioned this pull request Aug 31, 2020
Closed
@github-actions
Copy link
Contributor

📝 Docs preview for commit 48169100281c6e223432ae1c7e4e81f0b3ad1c18 at: https://5f4d05650889c637196d6375--fastapi.netlify.app

@komtaki komtaki force-pushed the translation/add-japanese-doc-benchmarks branch from 4816910 to 528f790 Compare September 2, 2020 05:23
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2020

📝 Docs preview for commit 528f790 at: https://5f4f38191b2e095367c3a63c--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

📝 Docs preview for commit 9049932 at: https://5f5267966666b311297675ee--fastapi.netlify.app

tokusumi
tokusumi suggested changes Sep 12, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate for translating difficult chapter.
I suggest some improvement. feel free to discuss my comments.

docs/ja/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ja/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ja/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ja/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ja/docs/benchmarks.md Outdated Show resolved Hide resolved
@komtaki
Copy link
Contributor Author

komtaki commented Sep 13, 2020

@tokusumi

Thanks for the review!! 👍
I fixed everything. So, check my fix please.

tokusumi
tokusumi approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Attsun1031
Attsun1031 reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work !
I suggested one minor correction, so please check.

docs/ja/docs/benchmarks.md Outdated Show resolved Hide resolved
@komtaki @Attsun1031
Add supplementary explanation.
1b5c93f 
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@komtaki
Copy link
Contributor Author

komtaki commented Oct 5, 2020

@Attsun1031

I appreciate for your review and suggestion. 😀
I applied your suggestion. Could you check ?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2020

📝 Docs preview for commit 1b5c93f at: https://5f7b2a92dd197318f3f34ff7--fastapi.netlify.app

Attsun1031
Attsun1031 approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Oct 15, 2020
@tiangolo tiangolo changed the title Add benchmarks.md Japanese ver. 🌐 Add Japanese translation for Benchmarks Oct 17, 2020
@tiangolo
Copy link
Member

Awesome, thanks @komtaki ! 🚀 ☕

And thanks @Attsun1031 and @tokusumi for the reviews 🍰 🙇

@tiangolo tiangolo merged commit d513680 into fastapi:master Oct 17, 2020
@komtaki komtaki deleted the translation/add-japanese-doc-benchmarks branch October 19, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Attsun1031 Attsun1031 Attsun1031 approved these changes

@tokusumi tokusumi tokusumi approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@komtaki @tiangolo @Attsun1031 @tokusumi