Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean translation for index.md #2014

Closed
wants to merge 3 commits into from

Conversation

hard-coders
Copy link
Sponsor Contributor

Greetings.

I added Korean doc and translated index.md.

Welcome any reviews!

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #2014 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2014   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77ea63...df0f1c0. Read the comment docs.

@ycd
Copy link
Contributor

ycd commented Sep 5, 2020

Awesome 🚀 🎉

But, i recommend you to split your Translation of Index.md and setup for Korean docs in two separate PR's

That way others can help with other pages while you work on others, also you might want to create a Issue named
[FEATURE] Korean translations to coordinate the translations.

@hard-coders
Copy link
Sponsor Contributor Author

Awesome 🚀 🎉

But, i recommend you to split your Translation of Index.md and setup for Korean docs in two separate PR's

That way others can help with other pages while you work on others, also you might want to create a Issue named
[FEATURE] Korean translations to coordinate the translations.

Thanks for your comment.
I will close this PR and separate it.

@tiangolo
Copy link
Owner

Thanks for the help @ycd ! ☕ 🍰

And thanks @hard-coders for your contribution. 🙇 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants