🌐 Add Japanese translation for Concurrency and async / await #2058
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 243 243
Lines 7419 7419
=========================================
Hits 7419 7419 Continue to review full report at Codecov.
|
|
📝 Docs preview for commit a8b57e8 at: https://5f61207d65823e35bb3a91dd--fastapi.netlify.app |
Co-authored-by: Taki Komiyama <39375566+komtaki@users.noreply.github.com>
|
📝 Docs preview for commit 25b888b at: https://5f6f14283bbe865e72b6fe5d--fastapi.netlify.app |
tiangolo
added
awaiting-review
lang-all
|
📝 Docs preview for commit af68dca at: https://5f8c3fb834376717567260a3--fastapi.netlify.app |
There was a problem hiding this comment.
It is a very interesting and impressive document, and I'm super appreciated with your hard work of the translation with this big volume!
Especially the original burger stories are written in very story telling style with a lot of Emojis, so I believe even the translation could be in more spoken form in Japanese, which would attract more people who are beginners of the FastAPI world!
I haven't changed so much, but tried to make it a bit easy to read. So please consider for the suggestions!
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
|
📝 Docs preview for commit 4d8bbe7 at: https://6003d346685d2641bcd72540--fastapi.netlify.app |
|
📝 Docs preview for commit 63a18fd at: https://6003d4838a2bbac9e5563254--fastapi.netlify.app |
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
|
📝 Docs preview for commit 3226a75 at: https://6004282aab6d721364aa7616--fastapi.netlify.app |
Co-authored-by: Sho Nakamura <sh0nk.developer@gmail.com>
|
📝 Docs preview for commit e862e2a at: https://60042d6d59b42bfb3e1bc214--fastapi.netlify.app |
|
📝 Docs preview for commit d9d4c23 at: https://6004308fe6f31a277e286917--fastapi.netlify.app |
|
@sh0nk Thank you for your review! |
There was a problem hiding this comment.
Looks very good to me 👍 Thank you for taking the suggestions with patience and persistence, even though the number is so huge!
Again, this doc must be a very impressive one for beginners of FastAPI to learn how and what is async! Not only that, I believe this is also good for people who are not the FastAPI users.
tiangolo
changed the title
This PR translates the async.md to Japanese.
This section is technical, descriptive and long. I translated loosely to make it easier to read for Japanese.
Feel free to comment your advise or approve.