Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for Advanced Tutorial - Response Directly #2191

Merged
merged 6 commits into from
Nov 5, 2020
Merged

🌐 Add Japanese translation for Advanced Tutorial - Response Directly #2191

merged 6 commits into from
Nov 5, 2020
+65 −0

Conversation

Attsun1031
Copy link
Contributor

This PR translates the advanced/response-directly.md to Japanese.

@Attsun1031 Attsun1031 mentioned this pull request Oct 18, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 18, 2020 •
edited
Loading

Codecov Report

Merging #2191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790fa21...30234f4. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit b04a24d at: https://5f8bddc92ff9405832abf230--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 7f66de3 at: https://5f8beb99f3a8268708266a0e--fastapi.netlify.app

tokusumi
tokusumi suggested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for great work!

docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
@Attsun1031 @tokusumi
Apply suggestions from code review
2a31143 
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@Attsun1031
Copy link
Contributor Author

@tokusumi Thank you for your review ! Every your suggestion are applied, so please check again.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 2a31143 at: https://5f9b6bc2a324101c9bb41006--fastapi.netlify.app

tokusumi
tokusumi approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cooperating!

komtaki
komtaki reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@komtaki komtaki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for your work. 👍

I commented a few small suggestions.

docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/response-directly.md Outdated Show resolved Hide resolved
@Attsun1031 @komtaki
Apply suggestions from code review
c78712e 
Co-authored-by: Taki Komiyama <39375566+komtaki@users.noreply.github.com>
@Attsun1031
Copy link
Contributor Author

@komtaki Thank you for your review ! I fixed everything, so please check again.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

📝 Docs preview for commit c78712e at: https://5fa21758817493444118613f--fastapi.netlify.app

komtaki
komtaki approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update 👍

@tiangolo tiangolo changed the title Add Japanese translation for Advanced - response-directly 🌐 Add Japanese translation for Advanced Tutorial - Response Directly Nov 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

📝 Docs preview for commit 30234f4 at: https://5fa480cb2fceaf012c696c06--fastapi.netlify.app

@tiangolo tiangolo merged commit d31648c into fastapi:master Nov 5, 2020
@tiangolo
Copy link
Member

tiangolo commented Nov 5, 2020

Awesome, thank you @Attsun1031 ! 🍰 🎉

And thanks for the reviews @komtaki and @tokusumi 🙇 ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komtaki komtaki komtaki approved these changes

@tokusumi tokusumi tokusumi approved these changes

Assignees
No one assigned
Labels
approved-2 hacktoberfest-accepted lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Attsun1031 @tiangolo @komtaki @tokusumi