-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for docs/ko/docs/python-types.md
#2267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2267 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 540 240 -300
Lines 13969 7101 -6868
===========================================
- Hits 13969 7101 -6868 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit eb3ac10 at: https://5f9bd3234b8985d7301987f1--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated #2017 a few days ago. I want you to follow it.
Sorry for the late update.😭
Co-authored-by: hard_coder <rurouni24@gmail.com>
Co-authored-by: hard_coder <rurouni24@gmail.com>
Co-authored-by: hard_coder <rurouni24@gmail.com>
Co-authored-by: hard_coder <rurouni24@gmail.com>
📝 Docs preview for commit d2a0e65 at: https://5fa53daa31aca1ff592e3b27--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are almost there!😎
But there's one more thing... to do. Please replace "에디터" with "편집기". It is also to follow python's official Korean docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your efforts.
I added some comments here.
I hope they can be of any help for you :)
``` | ||
|
||
!!! info | ||
Pydantic<에 대해 더 배우고 싶다면 <a href="https://pydantic-docs.helpmanual.io/" class="external-link" target="_blank">공식 문서</a>를 참고하세요.</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "참고하십시오/확인해보십시오." rather than "참고하세요." ?
Co-authored-by: SueNaeunYang <artisticsue@naver.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: SueNaeunYang <artisticsue@naver.com>
Co-authored-by: SueNaeunYang <artisticsue@naver.com>
Co-authored-by: SueNaeunYang <artisticsue@naver.com>
Co-authored-by: SueNaeunYang <artisticsue@naver.com>
Co-authored-by: SueNaeunYang <artisticsue@naver.com>
Co-authored-by: SueNaeunYang <artisticsue@naver.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Thanks for reviewing y'all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed some lines more, like
!!! tip
to
!!! tip "팁"
Please see reviews and modify what you can accept.
I hope this PR merged soon:D
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
docs/ko/docs/python-types.md
docs/ko/docs/python-types.md
docs/ko/docs/python-types.md
📝 Docs preview for commit 655e68d at: https://6499cd5a4a964606cbd74e3b--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been forgotten for a long time, so the Type Hints with Metadata Annotations section isn't reflected in this PR. Despite the problem, because it is well-translated, I approve it and will create a new pull request to add the section.
I'm sorry for not getting back to it sooner. 🙇🏻
Thank you! @jrim 🐱 And thanks for the reviews @hard-coders and @SueNaEunYang 🎉 |
Korean translated 'python-types.md' #2017