Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md #2415

Merged
merged 20 commits into from Jan 22, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md #2415

merged 20 commits into from Jan 22, 2024

Conversation

hard-coders
Copy link
Sponsor Contributor

This PR translates tutorial/query-params-str-validations.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Nov 25, 2020 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (3628921) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head 3628921 differs from pull request most recent head 238ab81. Consider uploading reports for the commit 238ab81 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #2415    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13684   -285     
==========================================
- Hits         13969     13684   -285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 37c5cbf at: https://5fbe363d5ff4c348af8cbdd9--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Nov 25, 2020
@hard-coders hard-coders mentioned this pull request May 11, 2021
Closed
0417taehyun
0417taehyun suggested changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@0417taehyun 0417taehyun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big appreciate of you works and great honor to check it.

Feel free to check my reviews 🚀

Also, please update (fetch) your files to latest version to solve the conflicts

docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/query-params-str-validations.md

이제는 더이상 이 매개변수를 마음에 들어하지 않는다고 가정해 봅시다.

이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다.
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다</abbr>고 확실하게 문서에서 보여주고 싶습니다.

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated means "it will be not used in near future". So I left the original word, deprecated.
How about

Suggested change
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않는다(deprecated)</abbr>고 확실하게 문서에서 보여주고 싶습니다.
이 매개변수를 사용하는 클라이언트가 있기 때문에 한동안은 남겨둬야 하지만, <abbr title="구식이며, 사용하지 않는 것을 추천">사용되지 않을 예정이다</abbr>라고 확실하게 문서에서 보여주고 싶습니다.

docs/ko/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
hard-coders and others added 8 commits November 21, 2021 16:40
@hard-coders
Merge branch 'master' into ko/tutorial/query-params-str-validation
c48ab10
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
baa1a20 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
50e8109 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
018dc37 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
b3ebd31 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
1b1b8da 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
d16069d 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
5c04347 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 5c04347 at: https://6199f903392a06d7423cfed1--fastapi.netlify.app

hard-coders and others added 7 commits November 21, 2021 16:46
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
82d48c6 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
102308d 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
531ca50 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
ea6e73f 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
940dae8 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
200f97c 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders
Update query-params-str-validations.md
1792199
@github-actions
Copy link
Contributor

📝 Docs preview for commit 1792199 at: https://6199fa7b281d3ad7cc51e2f5--fastapi.netlify.app

@hard-coders @0417taehyun
Update docs/ko/docs/tutorial/query-params-str-validations.md
0ad4e27 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@hard-coders
Copy link
Sponsor Contributor Author

Thanks to @kty4119 and especially @0417taehyun :D

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0ad4e27 at: https://6199fbfec6e9b4d4d5bbd426--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

📝 Docs preview for commit 3628921 at: https://62e89b7f7b0c347077f39a3e--fastapi.netlify.app

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by tiangolo#2415
27476c3
@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Query Parameters and String Validations 🌐 Add Korean translation for docs/ko/docs/tutorial/query-params-str-validations.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 238ab81 at: https://649a12bf7ce5230f7850e2a4--fastapi.netlify.app

@alejsdev alejsdev merged commit 87a4c9e into tiangolo:master Jan 22, 2024
32 checks passed
@alejsdev
Copy link
Collaborator

Thanks for your work @hard-coders 🪄

And thanks for the reviews @kty4119 and @0417taehyun 🤓✌️

@hard-coders hard-coders deleted the ko/tutorial/query-params-str-validation branch January 23, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kty4119 kty4119 kty4119 approved these changes

@0417taehyun 0417taehyun Awaiting requested review from 0417taehyun

Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hard-coders @tiangolo @alejsdev @kty4119 @0417taehyun