Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Chinese translation for Tutorial - Security - Security Intro #2443

Merged
merged 4 commits into from
Feb 7, 2021
Merged

🌐 Add Chinese translation for Tutorial - Security - Security Intro #2443

merged 4 commits into from
Feb 7, 2021

Conversation

waynerv
Copy link
Contributor

@waynerv waynerv commented Nov 30, 2020 •
edited
Loading

@maoyibo @RunningIkkyu @yanever Please take a look.

@waynerv waynerv mentioned this pull request Nov 30, 2020
Closed
@codecov
Copy link

codecov bot commented Nov 30, 2020 •
edited
Loading

Codecov Report

Merging #2443 (d1b8b34) into master (f031973) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2443   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb40e27...d1b8b34. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8f72424 at: https://5fc4a7d99ad37b5558257bbe--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 31e01c3 at: https://5fc4b9d2b9a5149e1bc63177--fastapi.netlify.app

maoyibo
maoyibo reviewed Nov 30, 2020
View reviewed changes
Copy link
Contributor

@maoyibo maoyibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

docs/zh/docs/tutorial/security/index.md Outdated Show resolved Hide resolved
docs/zh/docs/tutorial/security/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

📝 Docs preview for commit 0d7a19a at: https://5fc727814b9e27e24bd30b95--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-zh Chinese translations labels Dec 2, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit d1b8b34 at: https://5ffe5cd1aa727f4a12ec40c5--fastapi.netlify.app

@tiangolo tiangolo changed the title Add Chinese translation for Tutorial - Security - Security Intro 🌐 Add Chinese translation for Tutorial - Security - Security Intro Feb 7, 2021
@tiangolo
Copy link
Owner

tiangolo commented Feb 7, 2021

Great! Thank you @waynerv ! 🚀 🙇

And thanks for the reviews @maoyibo , @yanever , and @Laineyzhang55 🍰 ☕

@tiangolo tiangolo merged commit 9fda014 into tiangolo:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maoyibo maoyibo maoyibo left review comments

@yanever yanever yanever approved these changes

@Laineyzhang55 Laineyzhang55 Laineyzhang55 approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-zh Chinese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@waynerv @tiangolo @maoyibo @yanever @Laineyzhang55