New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for docs/ko/docs/tutorial/body-multiple-params.md
#2461
🌐 Add Korean translation for docs/ko/docs/tutorial/body-multiple-params.md
#2461
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2461 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 540 242 -298
Lines 13969 7396 -6573
===========================================
- Hits 13969 7396 -6573 ☔ View full report in Codecov by Sentry. |
Would it be better to translate |
I prefer
It is just a personal opinion, but I think you(@PandaHun) should leave them. 😃 |
📝 Docs preview for commit 96dc082 at: https://5fcd8b70f7ef2c709e108381--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 Thanks for your contribution! I think it's almost done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice work!
BTW, you could commit directly on Github by accepting reviews, and Github will approve it automatically when a reviewer approved with suggestions.
Otherwise, the reviewer has to approve it again.😂
docs/ko/docs/tutorial/body-multiple-params.md
📝 Docs preview for commit c6130d2 at: https://6499c97e1d7654037c04dcaa--fastapi.netlify.app |
Thanks for your contribution! @PandaHun 👨💻 And thanks for the review @hard-coders 💯 |
This PR translates
tutorial/body-multiple-params.md
in Koreanrelated: #2017