Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Start translation of the documentation for the Albanian language #2516

Merged
merged 2 commits into from
Dec 19, 2020
Merged

馃寪 Start translation of the documentation for the Albanian language #2516

merged 2 commits into from
Dec 19, 2020

Conversation

vjanz
Copy link
Contributor

@vjanz vjanz commented Dec 15, 2020

I want to contribute to translations for the Albanian language, so let's go 馃憤

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #2516 (da96dbb) into master (e6f8aa8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2516   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          242       242           
  Lines         7396      7396           
=========================================
  Hits          7396      7396           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d6b5bc9...da96dbb. Read the comment docs.

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit da96dbb at: https://5fd8a8a85a7b94dde96ccb8c--fastapi.netlify.app

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Dec 15, 2020

@vjanz Based on what I've seen, I recommend you to:

The reasons are:

  • Being able to coordinate the translations, so others can contribute.
  • To have translations merged, we need approvals from people that speaks the language. If there's a PR with only the setup, it can be merged right away and people can take their time to review the index.md. Besides, your PR will not block others to contribute with other pages.

@ycd
Copy link
Contributor

ycd commented Dec 15, 2020

@Kludex, i think he did it right 馃. Except creating a translation issue to coordinate translations 馃憤

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Dec 15, 2020

Did what? 馃

@ycd
Copy link
Contributor

ycd commented Dec 15, 2020

I mean the setup, anything wrong with it?

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Dec 15, 2020

Oh, I'm sorry. I assumed the index.md was already translated. 馃様 Yeah, everything is fine!

@vjanz
Copy link
Contributor Author

vjanz commented Dec 15, 2020

Hey @Kludex and @ycd, thank you for starting the conversation here.

To be more clear, I just did the initial setup on this PR as requested on docs, and I continued translating section by section on separate branches, so other people can contribute.

So I am thinking of making a separate PR for each section that I translate if that sounds right?

Cheers!

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Dec 15, 2020

To be more clear, I just did the initial setup on this PR as requested on docs, and I continued translating section by section on separate branches, so other people can contribute.

Yeah, it was my bad. I assumed the index.md was already translated.

So I am thinking of making a separate PR for each section that I translate if that sounds right?

It does! 馃帀

@tiangolo tiangolo added lang-all Translations lang-sq Albanian translations labels Dec 19, 2020
@tiangolo tiangolo changed the title Started translation of the documentation for the Albanian language 馃寪 Start translation of the documentation for the Albanian language Dec 19, 2020
@tiangolo tiangolo merged commit 7a2c552 into tiangolo:master Dec 19, 2020
@tiangolo
Copy link
Owner

Awesome! Thanks @vjanz ! 馃殌 馃帀

And thanks @Kludex and @ycd for the help here! 馃檱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-all Translations lang-sq Albanian translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants