Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Improve type annotations, add support for mypy --strict, internally and for external packages #2547

Merged
merged 13 commits into from
Dec 20, 2020
Merged

✨ Improve type annotations, add support for mypy --strict, internally and for external packages #2547

merged 13 commits into from
Dec 20, 2020

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Dec 20, 2020 •
edited
Loading

✨ Improve type annotations, add support for mypy --strict, internally and for external packages

This includes type annotation improvements in several places, including callbacks and OAuth2, that fix false-positive mypy errors.

@codecov
Copy link

codecov bot commented Dec 20, 2020 •
edited
Loading

Codecov Report

Merging #2547 (7955d83) into master (e2a6341) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2547   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          242       243    +1     
  Lines         7396      7419   +23     
=========================================
+ Hits          7396      7419   +23
Impacted Files Coverage Δ
fastapi/param_functions.py 100.00% <ø> (ø)
fastapi/params.py 100.00% <ø> (ø)
tests/test_sub_callbacks.py 100.00% <ø> (ø)
fastapi/applications.py 100.00% <100.00%> (ø)
fastapi/background.py 100.00% <100.00%> (ø)
fastapi/concurrency.py 100.00% <100.00%> (ø)
fastapi/datastructures.py 100.00% <100.00%> (ø)
fastapi/dependencies/models.py 100.00% <100.00%> (ø)
fastapi/dependencies/utils.py 100.00% <100.00%> (ø)
fastapi/encoders.py 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fdcdf3...7955d83. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2020 •
edited
Loading

🚀 Deployed on https://5fdf9c6679b5279a004e8a2a--fastapi.netlify.app

@github-actions github-actions bot temporarily deployed to commit December 20, 2020 17:48 Inactive
@github-actions github-actions bot temporarily deployed to commit December 20, 2020 17:49 Inactive
@github-actions
Copy link
Contributor

📝 Docs preview for commit f566e2a at: https://5fdf8ea8af9838c9d97e9a7b--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit f566e2a at: https://5fdf8eaaea9c7810560ce5ac--fastapi.netlify.app

@tiangolo tiangolo changed the title ✨ Add support for mypy --strict, internally and for external packages ✨ Improve type annotations, add support for mypy --strict, internally and for external packages Dec 20, 2020
@github-actions github-actions bot temporarily deployed to commit December 20, 2020 18:38 Inactive
@github-actions github-actions bot temporarily deployed to commit December 20, 2020 18:41 Inactive
@github-actions
Copy link
Contributor

📝 Docs preview for commit 7ed88fc at: https://5fdf9ac079b5279c8b4e89a5--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 7ed88fc at: https://5fdf9ad8d3466cb2a0ab315a--fastapi.netlify.app

@github-actions github-actions bot temporarily deployed to commit December 20, 2020 18:47 Inactive
@github-actions github-actions bot temporarily deployed to commit December 20, 2020 18:49 Inactive
@github-actions
Copy link
Contributor

📝 Docs preview for commit 7955d83 at: https://5fdf9c9440dec1a636da7bab--fastapi.netlify.app

@tiangolo tiangolo merged commit fdb6c9c into master Dec 20, 2020
@tiangolo tiangolo deleted the mypy-strict branch December 20, 2020 18:50
@tiangolo tiangolo mentioned this pull request Dec 20, 2020
Closed
This was referenced Dec 20, 2020
Closed
Closed
This was referenced Feb 7, 2021
Closed
Closed
@Kludex Kludex mentioned this pull request Dec 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tiangolo