Prefer custom encoder over defaults if specified. #2567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksunder
commented
Dec 24, 2020
| if type(obj) in custom_encoder: | ||
| return custom_encoder[type(obj)](obj) | ||
| else: | ||
| for encoder_type, encoder_instance in custom_encoder.items(): |
There was a problem hiding this comment.
mypy was getting confused because encoder is declared here in the for loop but also in the lines below. So I gave this var a different name here.
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 243 243
Lines 7419 7428 +9
=========================================
+ Hits 7419 7428 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In encoders.py/jsonable_encoder, default encoders for each type are specified first & are used in preference to custom encoders.
This affects custom encoders specified for certain types like enums such that the default encoder is always executed and any custom encoders specified are ignored. See - #1986 - for a description of this issue and example code as well that illustrates the problem.
This PR adds a change to prefer custom encoders if specified in preference to default encoders.