-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix support for prefix on APIRouter WebSockets #2640
Conversation
26dbf9a
to
8843fe8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2640 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 529 529
Lines 13510 13522 +12
=========================================
+ Hits 13510 13522 +12
Continue to review full report at Codecov.
|
📝 Docs preview for commit 8843fe8 at: https://5ffdf2b21695b70981f3a279--fastapi.netlify.app |
📝 Docs preview for commit 6d66350 at: https://5ffdf574c2eb990e055ca0d7--fastapi.netlify.app |
Any chance on getting this PR merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, would love to see this merged soon!
Is there any reason why this PR is still not merged? |
Hi! Will this PR get merged any time soon? It's been more than a year |
@tiangolo Please merge this! |
Why is this not merged yet ? Are you guys afraid it will deprecate existing code ? |
Awesome, thanks @Kludex as always! 🙇 🍰 Thanks everyone for your input. 🍪 This will be available in FastAPI version |
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Try this solved |
Related to #2639