Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/tutorial/response-model.md #2766

Merged
merged 4 commits into from Jan 22, 2024

Conversation

hard-coders
Copy link
Sponsor Contributor

This PR translates tutorial/response-model.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (da4472a) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head da4472a differs from pull request most recent head d86b5c3. Consider uploading reports for the commit d86b5c3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #2766     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       243    -297     
  Lines        13969      7419   -6550     
===========================================
- Hits         13969      7419   -6550     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2021

📝 Docs preview for commit 625fc30 at: https://601fa051b9896f4b5a4c4299--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Feb 7, 2021
Copy link
Contributor

@JeongHyeongKim JeongHyeongKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR was a good reference for me :)

and i opened PR(Korean Translation for Tutorial - Middleware) 5 days ago

i will modify my translation based on your PR

docs/ko/docs/tutorial/response-model.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit 10b7e99 at: https://603b2668060121ebf3536c1c--fastapi.netlify.app

@hard-coders
Copy link
Sponsor Contributor Author

It's weird. I ran mypy fastapi on local, and I got success 🤔

Copy link
Contributor

@jeesang7 jeesang7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

📝 Docs preview for commit da4472a at: https://606c4ff174696755ec49f27f--fastapi.netlify.app

@hard-coders hard-coders mentioned this pull request May 11, 2021
joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Response Model 🌐 Add Korean translation for docs/ko/docs/tutorial/response-model.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit d86b5c3 at: https://6499ccb57bcac500bf7f94b4--fastapi.netlify.app

@alejsdev
Copy link
Collaborator

Thanks! @hard-coders 😸

And thanks for the review @jeesang7 🎉

@alejsdev alejsdev merged commit 8ec9e30 into tiangolo:master Jan 22, 2024
32 checks passed
@hard-coders hard-coders deleted the ko/tutorial/response-model branch January 23, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants