-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆Increase supported version of aiofiles to suppress warnings #2899
⬆Increase supported version of aiofiles to suppress warnings #2899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2899 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 410 410
Lines 10281 10281
=========================================
Hits 10281 10281 Continue to review full report at Codecov.
|
📝 Docs preview for commit 6df49c9 at: https://6041a84dec518b4cc73f8876--fastapi.netlify.app |
Is there a reason why this PR is not merged yet? If any more work is needed, I'd be happy to jump in. |
In the meantime version 0.7.0 has been released. I recommend upgrading again. |
@wavenator The version of |
All reviewers have approved this pullreq. What's blocking the workflows? |
I came looking to open this PR today, good to see some activity. I can pitch some commentary on the changelog from aiofiles. 0.7.0 (2021-05-17)
''''''''''''''''''
- Added the ``aiofiles.tempfile`` module for async temporary files. <https://github.com/Tinche/aiofiles/pull/56>
- Switched to Poetry and GitHub actions.
- Dropped 3.5 support.
0.6.0 (2020-10-27)
''''''''''''''''''
- `aiofiles` is now tested on ppc64le.
- Added `name` and `mode` properties to async file objects. <https://github.com/Tinche/aiofiles/pull/82>
- Fixed a DeprecationWarning internally. <https://github.com/Tinche/aiofiles/pull/75>
- Python 3.9 support and tests.
|
Thanks @zevisert! |
📝 Docs preview for commit f00a27e at: https://615c178297b64adca31ade5b--fastapi.netlify.app |
Thanks for your contribution @SnkSynthesis! 🍰 And thanks for the discussion everyone, in particular @zevisert for all the investigation and report. 🕵️ I updated the range required to also include On the other hand, just as a note, I'll soon upgrade to the latest Starlette, based on I'm making a release with these changes first just in case that's useful in the transition for anyone. This is included in FastAPI |
Thanks @tiangolo 😄! |
With Python 3.8 the usage of this
@asyncio.coroutine
in aiofiles 0.5.0 raises warnings since the@asyncio.coroutine
has been deprecated since Python 3.8. This PR suppresses those warnings by increasing the aiofiles version to 0.7.0.The lines (
aiofiles/os.py
) of aiofiles in version 0.5.0 (Notice the@asyncio.coroutine
):The lines (
aiofiles/os.py
) of aiofiles in version 0.7.0 (Notice theasync def
):