Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/ko/docs/tutorial/static-files.md #2957

Merged
merged 9 commits into from Jan 22, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/tutorial/static-files.md #2957

merged 9 commits into from Jan 22, 2024

Conversation

jeesang7
Copy link
Contributor

This is my first PR translates tutorial/static-files.md in Korean.
Frankly, I'm not used to it yet, so I chose the part that I know well and don't feel pressured.
Please review the translation, thanks.

μ•ˆλ…•ν•˜μ„Έμš”, μ΄λ ‡κ²Œ λ²ˆμ—­ 기여에 μ°Έμ—¬ν•˜κ²Œ λ˜μ–΄ κΈ°μ©λ‹ˆλ‹€.
비둝 많이 λΆ€μ‘±ν•˜κ³  양도 μ μ§€λ§Œ, μ‘°κΈˆμ΄λΌλ„ 도움이 되고 μ‹Άμ–΄ PR μ˜¬λ¦½λ‹ˆλ‹€.
μ–΄μƒ‰ν•˜κ±°λ‚˜ 이견이 μžˆμœΌμ‹œλ©΄ ν”Όλ“œλ°± λΆ€νƒλ“œλ¦½λ‹ˆλ‹€. κ°μ‚¬ν•©λ‹ˆλ‹€.

related: #2017

@github-actions
Copy link
Contributor

πŸ“ Docs preview for commit 947e7a0 at: https://6050ce2433eed3da9f769efe--fastapi.netlify.app

@ArcLightSlavik
Copy link
Contributor

Could you change the name of PR to "Japanese translation for tutorial/static-files.md"

@jeesang7 jeesang7 changed the title 🌐 translate tutorial/static-files.md 🌐 Korean translation for tutorial/static-files.md Mar 17, 2021
@jeesang7
Copy link
Contributor Author

jeesang7 commented Mar 17, 2021 •
edited

Could you change the name of PR to "Japanese translation for tutorial/static-files.md"

Yes. But it's not Japanese, this is Korean.

@jeesang7 @JeongHyeongKim
Update docs/ko/docs/tutorial/static-files.md
2c54b2b 
Co-authored-by: JeongHyeongKim <maladroit1@likelion.org>
@github-actions
Copy link
Contributor

πŸ“ Docs preview for commit 2c54b2b at: https://60520b612587cdbe69847cd6--fastapi.netlify.app

akagaeng
akagaeng reviewed Mar 19, 2021
View reviewed changes
Copy link

@akagaeng akagaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

살짝 μžμ—°μŠ€λŸ½κ²Œ 닀듬어 λ΄€μŠ΅λ‹ˆλ‹€ :)

docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
jeesang7 and others added 2 commits March 20, 2021 21:32
@jeesang7 @akagaeng
Update docs/ko/docs/tutorial/static-files.md
ae72706 
Co-authored-by: ks.yang <akagaeng@users.noreply.github.com>
@jeesang7 @akagaeng
Update docs/ko/docs/tutorial/static-files.md
e1e668e 
Co-authored-by: ks.yang <akagaeng@users.noreply.github.com>
@github-actions
Copy link
Contributor

πŸ“ Docs preview for commit e1e668e at: https://6055ebe09d13821e1e0c6977--fastapi.netlify.app

@github-actions
Copy link
Contributor

πŸ“ Docs preview for commit e1e668e at: https://6055ebeabd9a04f80ba3a710--fastapi.netlify.app

@jeesang7
Copy link
Contributor Author

살짝 μžμ—°μŠ€λŸ½κ²Œ 닀듬어 λ΄€μŠ΅λ‹ˆλ‹€ :)

훨씬 μžμ—°μŠ€λŸ¬μš΄ 것 κ°™μŠ΅λ‹ˆλ‹€ πŸ˜„

@tiangolo tiangolo changed the title 🌐 Korean translation for tutorial/static-files.md 🌐 Korean translation for Tutorial - Static Files Mar 27, 2021
@tiangolo tiangolo changed the title 🌐 Korean translation for Tutorial - Static Files 🌐 Add Korean translation for Tutorial - Static Files Mar 27, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Mar 27, 2021
@hard-coders hard-coders mentioned this pull request May 11, 2021
Closed
0417taehyun
0417taehyun suggested changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big appreciate of your works and great honor to check it.

Feel free to check my reviews πŸš€

I think the aiofiles section was deprecated so please update (fetch) the your file to the latest version.

docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated

### "λ§ˆμš΄νŒ…" μ΄λž€

"λ§ˆμš΄νŒ…"은 νŠΉμ • κ²½λ‘œμ— μ™„μ „ν•œ "독립적인" μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ„ μΆ”κ°€ν•˜λŠ” 것을 λ§ν•˜λŠ”λ°, κ·Έ ν›„μ—λŠ” λͺ¨λ“  ν•˜μœ„ κ²½λ‘œμ— λŒ€ν•΄μ„œλ„ μ μš©λ©λ‹ˆλ‹€.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"λ§ˆμš΄νŒ…"은 νŠΉμ • κ²½λ‘œμ— μ™„μ „ν•œ "독립적인" μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ„ μΆ”κ°€ν•˜λŠ” 것을 λ§ν•˜λŠ”λ°, κ·Έ ν›„μ—λŠ” λͺ¨λ“  ν•˜μœ„ κ²½λ‘œμ— λŒ€ν•΄μ„œλ„ μ μš©λ©λ‹ˆλ‹€.
"λ§ˆμš΄νŒ…"은 νŠΉμ • κ²½λ‘œμ— μ™„μ „νžˆ "독립적인" μ‘μš© ν”„λ‘œκ·Έλž¨μ„ μΆ”κ°€ν•˜λŠ” 것을 μ˜λ―Έν•˜λŠ”λ°, κ·Έ ν›„ λͺ¨λ“  ν•˜μœ„ κ²½λ‘œμ— λŒ€ν•΄μ„œλ„ μ μš©λ©λ‹ˆλ‹€.

docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/static-files.md Outdated Show resolved Hide resolved
jeesang7 and others added 2 commits November 7, 2021 16:34
@jeesang7 @0417taehyun
Apply suggestions from code review
4d5409f 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@jeesang7
Merge branch 'master' into ko/tutorial/static-files
f79b3c2
@JeongHyeongKim JeongHyeongKim mentioned this pull request Feb 22, 2022
Closed
joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by tiangolo#2957
a322303
@joonas-yoon joonas-yoon mentioned this pull request Nov 5, 2022
Closed
@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Static Files 🌐 Add Korean translation for docs/ko/docs/tutorial/static-files.md Jun 26, 2023
@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit a52b9eb at: https://6499e2c757a4bc039ac9416d--fastapi.netlify.app

@jeesang7 @0417taehyun
Apply suggestions from code review
6fa91ab 
change `μ• ν”Œλ¦¬μΌ€μ΄μ…˜` to `μ‘μš© ν”„λ‘œκ·Έλž¨`

Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 6fa91ab at: https://8a20da10.fastapitiangolo.pages.dev

akagaeng
akagaeng approved these changes Jan 17, 2024
View reviewed changes
Copy link

@akagaeng akagaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejsdev alejsdev merged commit ea6e0ff into tiangolo:master Jan 22, 2024
41 checks passed
@alejsdev
Copy link
Collaborator

Thanks for your contribution! @jeesang7 πŸ˜ƒ

And thanks for the review @akagaeng β˜•

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akagaeng akagaeng akagaeng approved these changes

@0417taehyun 0417taehyun Awaiting requested review from 0417taehyun

@JeongHyeongKim JeongHyeongKim Awaiting requested review from JeongHyeongKim

Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jeesang7 @ArcLightSlavik @tiangolo @alejsdev @akagaeng @JeongHyeongKim @0417taehyun