Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SQLAlchemy support, including ORM. And update docs accordingly.
jsonable_encoder
to support SQLAlchemy models by default, with a newsqlalchemy_safe
parameter that checks for keys specific to SQLAlchemy.This is related to #4 (and it should fix it), might be related to #27 (as the current tutorial is broken). This new tutorial, fix and code should simplify starting with SQLAlchemy.
At some point, it could make sense to add (or replace) instructions for Starlette's integrated database utils, or the new https://github.com/encode/databases and PR #20.
Let's see how it all evolves. For now, this should work in a simple way, supporting SQLAlchemy ORM (that is not possible otherwise). This should also make it easier for people coming from mainstream frameworks like Flask and Django.