Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Vietnamese translation for docs/vi/docs/features.md and docs/vi/docs/index.md #3006

Merged
merged 11 commits into from Jul 27, 2023

Conversation

magiskboy
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (1750054) 100.00%.

❗ Current head 1750054 differs from pull request most recent head 11843cd. Consider uploading reports for the commit 11843cd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #3006     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       243    -297     
  Lines        13969      7419   -6550     
===========================================
- Hits         13969      7419   -6550     

see 349 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0fc611d at: https://60608f72a70a457b59ce907b--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1750054 at: https://6060ae03b6b86a89f1d79b39--fastapi.netlify.app

@tiangolo tiangolo changed the title Init vietnamese's doc 🌐 Start Vietnamese translation, including translation of main page Jul 3, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-vi Vietnamese translations labels Jul 3, 2021
@tiangolo
Copy link
Owner

📝 Docs preview for commit 43343a3 at: https://6485b02e09e5ab0857779339--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 5464352 at: https://6485b2a1aab7f404c566163a--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 39dbc62 at: https://6485d5976038ce1a744f62f6--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 5024084 at: https://648683e0ad38cc78b71d3ca7--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 3372c2e at: https://64868f95ce3df7085688fc19--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 9f6d6be at: https://648ae4e911066302f84f3ef4--fastapi.netlify.app

@magiskboy
Copy link
Contributor Author

@tiangolo what do you need to do on this pr?

@tiangolo tiangolo changed the title 🌐 Start Vietnamese translation, including translation of main page 🌐 Add Vietnamese translation for docs/vi/docs/features.md and docs/vi/docs/index.md Jun 27, 2023
@tiangolo
Copy link
Owner

tiangolo commented Jun 27, 2023

Nice! 🚀

To take it I would need to PR approvals from native speakers. If you have colleagues that would like to contribute, that would be best. You can read more about it in the docs: https://fastapi.tiangolo.com/contributing/#translations

A tip: it would probably be better to separate this PR in two, one for each file. That way it's gonna be easier for people to review it. And if they approve one file in one PR, I can merge that one, even if the other file is not ready yet.

@tiangolo
Copy link
Owner

📝 Docs preview for commit 11843cd at: https://649a30e2ec68df215ae6b31b--fastapi.netlify.app

@tiangolo
Copy link
Owner

I just added a GitHub Discussion to coordinate the Vietnamese translations here: #9752

Copy link

@vuamitom vuamitom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation looks good to me

@tiangolo
Copy link
Owner

Thank you @magiskboy! 🚀

And thanks for the reviews @phamquanganh31101998 and @vuamitom! 🙇

There are now Vietnamese translations for the FastAPI docs thanks to you! 🎉

@tiangolo tiangolo merged commit 1d088ea into tiangolo:master Jul 27, 2023
32 checks passed
erosennin pushed a commit to erosennin/fastapi that referenced this pull request Jul 31, 2023
…/vi/docs/index.md` (tiangolo#3006)

Co-authored-by: Nguyen Khac Thanh <nkthanh@Nguyens-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-vi Vietnamese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants