New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Vietnamese translation for docs/vi/docs/features.md
and docs/vi/docs/index.md
#3006
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3006 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 540 243 -297
Lines 13969 7419 -6550
===========================================
- Hits 13969 7419 -6550 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 0fc611d at: https://60608f72a70a457b59ce907b--fastapi.netlify.app |
📝 Docs preview for commit 1750054 at: https://6060ae03b6b86a89f1d79b39--fastapi.netlify.app |
📝 Docs preview for commit 43343a3 at: https://6485b02e09e5ab0857779339--fastapi.netlify.app |
📝 Docs preview for commit 5464352 at: https://6485b2a1aab7f404c566163a--fastapi.netlify.app |
📝 Docs preview for commit 39dbc62 at: https://6485d5976038ce1a744f62f6--fastapi.netlify.app |
📝 Docs preview for commit 5024084 at: https://648683e0ad38cc78b71d3ca7--fastapi.netlify.app |
📝 Docs preview for commit 3372c2e at: https://64868f95ce3df7085688fc19--fastapi.netlify.app |
📝 Docs preview for commit 9f6d6be at: https://648ae4e911066302f84f3ef4--fastapi.netlify.app |
@tiangolo what do you need to do on this pr? |
docs/vi/docs/features.md
and docs/vi/docs/index.md
Nice! 🚀 To take it I would need to PR approvals from native speakers. If you have colleagues that would like to contribute, that would be best. You can read more about it in the docs: https://fastapi.tiangolo.com/contributing/#translations A tip: it would probably be better to separate this PR in two, one for each file. That way it's gonna be easier for people to review it. And if they approve one file in one PR, I can merge that one, even if the other file is not ready yet. |
📝 Docs preview for commit 11843cd at: https://649a30e2ec68df215ae6b31b--fastapi.netlify.app |
I just added a GitHub Discussion to coordinate the Vietnamese translations here: #9752 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation looks good to me
Thank you @magiskboy! 🚀 And thanks for the reviews @phamquanganh31101998 and @vuamitom! 🙇 There are now Vietnamese translations for the FastAPI docs thanks to you! 🎉 |
…/vi/docs/index.md` (tiangolo#3006) Co-authored-by: Nguyen Khac Thanh <nkthanh@Nguyens-MacBook-Pro.local> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
No description provided.