Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Add Korean translation for docs/ko/docs/tutorial/schema-extra-example.md #3161

Closed
wants to merge 2 commits into from

Conversation

SueNaEunYang
Copy link
Contributor

Hello,
I added a translation of this part of the tutorial.
I would be grateful if you take a look if I had made any mistakes or mistranslations.
Please feel free to tell me if there's something to be improved.
Thank you.

This PR translates tutorial/schema-extra-example.md in Korean.
related: #2017

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #3161 (4a916cd) into master (ce0ec06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2252837...4a916cd. Read the comment docs.

Copy link
Owner

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you! 馃檱

There's a new file at docs/ko/docs/img/tutorial/body-fields/image01.png

You should be able to use the same example images for the English version, that way it's not necessary to duplicate the files.

The way the <img> HTML tag is written already takes advantage of this, so you can just remove that file. 馃

@tiangolo tiangolo added the lang-all Translations label May 4, 2021
@tiangolo tiangolo changed the title 馃寪 Add Korean translation for Tutorial / Schema Extra-Example 馃寪 Add Korean translation for Tutorial - Schema Extra - Example May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

馃摑 Docs preview for commit 83f2477 at: https://609108f4ce727ef5aa7cd325--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-ko Korean translations labels May 4, 2021
@SueNaEunYang SueNaEunYang requested a review from tiangolo May 4, 2021 08:53
@SueNaEunYang
Copy link
Contributor Author

@tiangolo
Hello, thank you for your review.
I removed the image file right away :)

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

馃摑 Docs preview for commit 4a916cd at: https://60910bfe4c3abffe77b0f7a9--fastapi.netlify.app

@DevDae DevDae mentioned this pull request Oct 9, 2021
@0417taehyun
Copy link
Contributor

Can you update (fetch) this document to the latest version? Because some of sentences are deprecated.

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo tiangolo changed the title 馃寪 Add Korean translation for Tutorial - Schema Extra - Example 馃寪 Add Korean translation for docs/ko/docs/tutorial/schema-extra-example.md Jun 26, 2023
@tiangolo tiangolo removed their request for review January 31, 2024 13:51
@alejsdev
Copy link
Collaborator

alejsdev commented Feb 9, 2024

Thank you for your contribution @SueNaEunYang 馃殌

However, we have decided to close this pull request as another one (#11121), which includes more recent updates, has already been merged. We appreciate your effort and encourage you to continue contributing in the future. Please feel free to check out the other open issues and PRs. Thanks! 馃

@alejsdev alejsdev closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants