-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃寪 Add Korean translation for docs/ko/docs/tutorial/schema-extra-example.md
#3161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 243 243
Lines 7419 7419
=========================================
Hits 7419 7419 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you! 馃檱
There's a new file at docs/ko/docs/img/tutorial/body-fields/image01.png
You should be able to use the same example images for the English version, that way it's not necessary to duplicate the files.
The way the <img>
HTML tag is written already takes advantage of this, so you can just remove that file. 馃
馃摑 Docs preview for commit 83f2477 at: https://609108f4ce727ef5aa7cd325--fastapi.netlify.app |
@tiangolo |
馃摑 Docs preview for commit 4a916cd at: https://60910bfe4c3abffe77b0f7a9--fastapi.netlify.app |
Can you update (fetch) this document to the latest version? Because some of sentences are deprecated. |
docs/ko/docs/tutorial/schema-extra-example.md
Thank you for your contribution @SueNaEunYang 馃殌 However, we have decided to close this pull request as another one (#11121), which includes more recent updates, has already been merged. We appreciate your effort and encourage you to continue contributing in the future. Please feel free to check out the other open issues and PRs. Thanks! 馃 |
Hello,
I added a translation of this part of the tutorial.
I would be grateful if you take a look if I had made any mistakes or mistranslations.
Please feel free to tell me if there's something to be improved.
Thank you.
This PR translates
tutorial/schema-extra-example.md
in Korean.related: #2017