🔧 Swap light/dark theme button icon #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frinzekt
approved these changes
May 24, 2021
tiangolo
changed the title
|
Nice, thanks @eddsalkield! And thanks for taking the time to explain the argument. 🤓 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #3246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 409 409
Lines 10264 10264
=========================================
Hits 10264 10264 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a very minor PR for the FastAPI docs that swaps the light/dark theme icons around. Currently the dark mode icon has the bulb filled (on) in the dark theme, and outlined (off) in the light theme.
Although not particularly important, most UI elements display the current state of affairs, rather than represent what will change when activated - for example, buttons are depressed when selected, not depressed prior to selection. This PR simply aims to make the UX more consistent.