-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add French translation for Tutorial - First steps #3455
🌐 Add French translation for Tutorial - First steps #3455
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3455 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 409 409
Lines 10264 10264
=========================================
Hits 10264 10264 Continue to review full report at Codecov.
|
📝 Docs preview for commit 0087ccb at: https://60e06aaba3ec238127dc5d41--fastapi.netlify.app |
I just reviewed this PR (as a native french speaker) and it looks good to me. Can be merged imo |
📝 Docs preview for commit 167325d at: https://60f2f50f3d0afb1c8a1a5a84--fastapi.netlify.app |
📝 Docs preview for commit 6c108c8 at: https://6164a090d4fe3b1ca1b4f386--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for the translation :)
I noticed a small typo which could be changed I guess.
In the last comment I'm nitpicking, feel free to close the thread if the change doesn't feel natural to you 👍
Thanks :)
📝 Docs preview for commit c0a6c81 at: https://61758785a5f84bd2a8e1450b--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM too :)
Great, thank you @Smlep! 🍰 And thanks for the reviews @AlexandreBiguet, @Cajuteq, and @krocdort 🙇 ☕ |
Hey everyone! 👋
Here is the PR to translate the first steps page of the tutorial documentation into french.
See the french translation tracking issue here.
Thanks for the reviews👌