Skip to content

Conversation

@Smlep
Copy link
Contributor

@Smlep Smlep commented Jul 3, 2021

Hey everyone! 👋

Here is the PR to translate the first steps page of the tutorial documentation into french.
See the french translation tracking issue here.

Thanks for the reviews👌

@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #3455 (0414c1d) into master (08410ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3455   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10264     10264           
=========================================
  Hits         10264     10264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08410ca...0414c1d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2021

📝 Docs preview for commit 0087ccb at: https://60e06aaba3ec238127dc5d41--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-fr French translations labels Jul 3, 2021
@Cajuteq
Copy link
Contributor

Cajuteq commented Jul 16, 2021

I just reviewed this PR (as a native french speaker) and it looks good to me. Can be merged imo

@github-actions
Copy link
Contributor

📝 Docs preview for commit 167325d at: https://60f2f50f3d0afb1c8a1a5a84--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 6c108c8 at: https://6164a090d4fe3b1ca1b4f386--fastapi.netlify.app

Copy link

@AlexandreBiguet AlexandreBiguet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the translation :)

I noticed a small typo which could be changed I guess.

In the last comment I'm nitpicking, feel free to close the thread if the change doesn't feel natural to you 👍

Thanks :)

@github-actions
Copy link
Contributor

📝 Docs preview for commit c0a6c81 at: https://61758785a5f84bd2a8e1450b--fastapi.netlify.app

Copy link

@AlexandreBiguet AlexandreBiguet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM too :)

@tiangolo
Copy link
Member

Great, thank you @Smlep! 🍰

And thanks for the reviews @AlexandreBiguet, @Cajuteq, and @krocdort 🙇 ☕

@tiangolo tiangolo enabled auto-merge (squash) October 26, 2021 18:44
@tiangolo tiangolo merged commit 652cf4b into fastapi:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-fr French translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants