Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Add a missing comma in the security tutorial #3564

Merged

Conversation

jalvaradosegura
Copy link
Contributor

There is a missing comma in the list of things that the paragraph is mentioning

@tiangolo tiangolo enabled auto-merge (squash) July 21, 2021 12:49
@tiangolo
Copy link
Member

Good catch, thank you @jalvaradosegura! 🙇 🔍

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #3564 (96e0364) into master (eb453a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3564   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10264     10264           
=========================================
  Hits         10264     10264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb453a5...96e0364. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 270cc2d at: https://60f818275bc56534a985a4cf--fastapi.netlify.app

auto-merge was automatically disabled July 21, 2021 16:22

Pull request was closed

@jalvaradosegura
Copy link
Contributor Author

More than happy to contribute to this incredible framework @tiangolo 🙇‍♂️

I have one question though. It seems that something is happening with the build-docs check, is taking quite a while.
I tried to solve this by closing and then opening the PR as stated in this answer

Is this normal? Am I not doing something? What should I do?

This is my first time contributing to a repository of this level, I'm tagging some of the FastAPI experts to kindly ask for their help🙏 @Kludex @frankie567

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

📝 Docs preview for commit 29fce2d at: https://615f0160201e9225059b0769--fastapi.netlify.app

@tiangolo tiangolo enabled auto-merge (squash) October 7, 2021 14:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

📝 Docs preview for commit 96e0364 at: https://615f04f14150f337c9f95e09--fastapi.netlify.app

@tiangolo tiangolo merged commit e43f434 into fastapi:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants