Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/features.md #4137

Closed
wants to merge 7 commits into from

Conversation

kty4119
Copy link
Contributor

@kty4119 kty4119 commented Nov 4, 2021

  • Add Korean translation for docs/ko/docs/features.md
  • Related [FEATURE] Korean translations [FEATURE] Korean translations Korean translations #2017

Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, i'm really gratitude for your works!
Feel free to my opinions and please give your idea 😁

docs/ko/docs/features.md Outdated Show resolved Hide resolved
docs/ko/docs/features.md Outdated Show resolved Hide resolved
kty4119 and others added 2 commits November 22, 2021 14:52
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/ko/docs/features 🌐 Add Korean translation for docs/ko/docs/features.md Dec 8, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
@joonas-yoon
Copy link
Contributor

Oh my. I didn't know about this PR.

I requested new PR and it has no conflict to merge into master branch - #5237


- [**Swagger UI**](https://github.com/swagger-api/swagger-ui), 에서 대화형 탐색을 통해, 브라우저에서 직접 API를 호출하고 테스트할 수 있습니다.

[![Swagger UI interaction](https://camo.githubusercontent.com/b8ead36860df4f2befd2203bfa1da701c57c09ceb16e4ac6b9881d698e9950ce/68747470733a2f2f666173746170692e7469616e676f6c6f2e636f6d2f696d672f696e6465782f696e6465782d30332d737761676765722d30322e706e67)](https://camo.githubusercontent.com/b8ead36860df4f2befd2203bfa1da701c57c09ceb16e4ac6b9881d698e9950ce/68747470733a2f2f666173746170692e7469616e676f6c6f2e636f6d2f696d672f696e6465782f696e6465782d30332d737761676765722d30322e706e67)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[![Swagger UI interaction](https://camo.githubusercontent.com/b8ead36860df4f2befd2203bfa1da701c57c09ceb16e4ac6b9881d698e9950ce/68747470733a2f2f666173746170692e7469616e676f6c6f2e636f6d2f696d672f696e6465782f696e6465782d30332d737761676765722d30322e706e67)](https://camo.githubusercontent.com/b8ead36860df4f2befd2203bfa1da701c57c09ceb16e4ac6b9881d698e9950ce/68747470733a2f2f666173746170692e7469616e676f6c6f2e636f6d2f696d672f696e6465782f696e6465782d30332d737761676765722d30322e706e67)
![Swagger UI interaction](https://fastapi.tiangolo.com/img/index/index-03-swagger-02.png)

For these files you can keep the original ones instead.

@tiangolo
Copy link
Owner

📝 Docs preview for commit ce3ce9e at: https://649a1544ce5a7609ebde0faf--fastapi.netlify.app

@tiangolo
Copy link
Owner

As this PR had requested changes to be applied but has been inactive for a while, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

@tiangolo tiangolo closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants