Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Add Korean translation for docs/ko/docs/help-fastapi.md #4139

Merged
merged 4 commits into from Apr 2, 2024

Conversation

kty4119
Copy link
Contributor

@kty4119 kty4119 commented Nov 4, 2021

  • Add Korean translation for docs/ko/docs/help-fastapi.md
  • Related [FEATURE] Korean translations [FEATURE] Korean translations [FEATURE] Korean translations Korean translations聽#2017

Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your hard works! 馃檹
I will wait your comments, thank you!

docs/ko/docs/help-fastapi.md Show resolved Hide resolved
docs/ko/docs/help-fastapi.md Show resolved Hide resolved
docs/ko/docs/help-fastapi.md Show resolved Hide resolved
docs/ko/docs/help-fastapi.md Show resolved Hide resolved
docs/ko/docs/help-fastapi.md Show resolved Hide resolved
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo
Copy link
Owner

馃摑 Docs preview for commit b033d64 at: https://6499e34684c0620543c16807--fastapi.netlify.app

@tiangolo tiangolo requested a review from DevDae January 15, 2024 15:48
@tiangolo
Copy link
Owner

Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Korean translations, that way if they are approved by each other, I could merge them. 馃

https://github.com/tiangolo/fastapi/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Alang-ko+label%3Aawaiting-review

Maybe @DevDae could review it again after the requested changes? 馃檹

@alejsdev alejsdev merged commit 5a29797 into tiangolo:master Apr 2, 2024
32 checks passed
@alejsdev
Copy link
Collaborator

alejsdev commented Apr 2, 2024

Thanks for the help! @kty4119 馃 馃挴

And thanks for the reviews @DevDae @junah201 馃攳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants