Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/benchmarks.md #4142

Closed
wants to merge 10 commits into from
Closed

🌐 Add Korean translation for docs/benchmarks.md #4142

wants to merge 10 commits into from

Conversation

kimjaeyoonn
Copy link
Contributor

I'm posting a new PR because there are a few things that need to be corrected through feedback.
Thank you 😆

Add Korean translation for ko/docs/benchmarks.md
Related [FEATURE] Korean translations [FEATURE] Korean translations [FEATURE] Korean translations #2017

@kimjaeyoonn kimjaeyoonn changed the title 🌐 Add Korean translation for docs/benchmarks.md 🌐 Add Korean translation for docs/benchmarks.md Nov 4, 2021
DongwonGim
DongwonGim reviewed Nov 4, 2021
View reviewed changes
Copy link

@DongwonGim DongwonGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starlette 및 Uvicorn보다 낮습니다.
->
Starlette과 Uvicorn 다음으로 높은 순위입니다.

0417taehyun
0417taehyun suggested changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@0417taehyun 0417taehyun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is my mistake 😭

docs/ko/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ko/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ko/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ko/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ko/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ko/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/ko/docs/benchmarks.md Outdated Show resolved Hide resolved
kimjaeyoonn and others added 7 commits November 17, 2021 14:58
@kimjaeyoonn @0417taehyun
Update docs/ko/docs/benchmarks.md
27af311 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@kimjaeyoonn @0417taehyun
Update docs/ko/docs/benchmarks.md
1baf465 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@kimjaeyoonn @0417taehyun
Update docs/ko/docs/benchmarks.md
c4cc86a 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@kimjaeyoonn @0417taehyun
Update docs/ko/docs/benchmarks.md
c0ac9ab 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@kimjaeyoonn @0417taehyun
Update docs/ko/docs/benchmarks.md
db0b6c8 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@kimjaeyoonn @0417taehyun
Update docs/ko/docs/benchmarks.md
95a2c21 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@kimjaeyoonn @0417taehyun
Update docs/ko/docs/benchmarks.md
9e50b0f 
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@kimjaeyoonn
Copy link
Contributor Author

I have accepted the feedback. Thank you @0417taehyun 😆
And I'm sure there are no more problems with the translation of this document.

@tiangolo I think you can merge this PR :)

@kimjaeyoonn
Update benchmarks.md
e476199 
@DongwonGim    
I have accepted your feedback. Thankyou 🚀

@tiangolo
I hope you merge this document.
There are many documents still open in #2017. 
I'm curious as to why it can't be merged. 
Even if it's not perfect, if you merge it, it will be easier for people to find parts to fix on the FastAPI webpage, so please merge it.
@kimjaeyoonn
Copy link
Contributor Author

@DongwonGim
I have accepted your feedback. Thankyou 🚀

@tiangolo
I hope you merge this document.
There are many documents still open in #2017.
I'm curious as to why it can't be merged.
Even if it's not perfect, if you merge it, it will be easier for people to find parts to fix on the FastAPI webpage, so please merge it.

DevDae
DevDae approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I review all works and check there is nothing to revise!
Appreciate you, @kimjaeyoonn 🚀

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
Closed
@tiangolo
Copy link
Owner

tiangolo commented Dec 8, 2021

Thanks for the contribution @kimjaeyoonn! As I don't speak the language, I merge translation PRs after they have 2 approving reviews. 🤓

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by tiangolo#4142
9c2b43f
@kimjaeyoonn kimjaeyoonn closed this by deleting the head repository Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DongwonGim DongwonGim DongwonGim left review comments

@0417taehyun 0417taehyun 0417taehyun requested changes

@DevDae DevDae DevDae approved these changes

Assignees
No one assigned
Labels
awaiting-review lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kimjaeyoonn @tiangolo @DongwonGim @0417taehyun @DevDae