Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md #4170

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

NinaHwang
Copy link
Contributor

This PR translates tutorial/sql-databases.md in Korean.

related: #2017

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (0b301ae) 100.00%.

❗ Current head 0b301ae differs from pull request most recent head d21f758. Consider uploading reports for the commit d21f758 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #4170     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       409    -131     
  Lines        13969     10264   -3705     
===========================================
- Hits         13969     10264   -3705     

see 177 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 7a94c05 at: https://618cba212a9dccd423d4ef2e--fastapi.netlify.app

Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your works!
Please check my review and give your opinions 😄
Thanks 🚀

docs/ko/docs/tutorial/sql-databases.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/sql-databases.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/sql-databases.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/sql-databases.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/sql-databases.md Show resolved Hide resolved
NinaHwang and others added 4 commits November 25, 2021 10:02
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 0822f0f at: https://619ee12925633b2bdce2fad1--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

📝 Docs preview for commit d4b5966 at: https://61b15a1d062b8498cac19477--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

📝 Docs preview for commit 0b301ae at: https://61b2131e9b67f479a0e920f7--fastapi.netlify.app

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/tutorial/sql-databases.md 🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit d21f758 at: https://649a1d1605f6af15bed6d0a4--fastapi.netlify.app

@tiangolo
Copy link
Owner

Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Korean translations, that way if they are approved by each other, I could merge them. 🤓

https://github.com/tiangolo/fastapi/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Alang-ko+label%3Aawaiting-review

Maybe @DevDae could review again after the requested changes? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants