-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for docs/ko/docs/tutorial/sql-databases.md
#4170
base: master
Are you sure you want to change the base?
Conversation
Test complete related: tiangolo#2017
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4170 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 540 409 -131
Lines 13969 10264 -3705
===========================================
- Hits 13969 10264 -3705 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 7a94c05 at: https://618cba212a9dccd423d4ef2e--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate your works!
Please check my review and give your opinions 😄
Thanks 🚀
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
Co-authored-by: daehyeon kim <87962045+DevDae@users.noreply.github.com>
📝 Docs preview for commit 0822f0f at: https://619ee12925633b2bdce2fad1--fastapi.netlify.app |
📝 Docs preview for commit d4b5966 at: https://61b15a1d062b8498cac19477--fastapi.netlify.app |
📝 Docs preview for commit 0b301ae at: https://61b2131e9b67f479a0e920f7--fastapi.netlify.app |
docs/tutorial/sql-databases.md
docs/ko/docs/tutorial/sql-databases.md
📝 Docs preview for commit d21f758 at: https://649a1d1605f6af15bed6d0a4--fastapi.netlify.app |
Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Korean translations, that way if they are approved by each other, I could merge them. 🤓 Maybe @DevDae could review again after the requested changes? 🙏 |
This PR translates tutorial/sql-databases.md in Korean.
related: #2017