-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Update Korean translation for docs/ko/docs/tutorial/first-steps.md
, docs/ko/docs/tutorial/index.md
, docs/ko/docs/tutorial/path-params.md
, and docs/ko/docs/tutorial/query-params.md
#4218
Conversation
docs/ko/docs/tutorial/first-steps.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4218 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 540 532 -8
Lines 13969 13672 -297
==========================================
- Hits 13969 13672 -297 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 34956d6 at: https://62a8480cab162c705ad73c97--fastapi.netlify.app |
docs/ko/docs/tutorial/first-steps.md
docs/ko/docs/tutorial/first-steps.md
, docs/ko/docs/tutorial/index.md
, docs/ko/docs/tutorial/path-params.md
, and docs/ko/docs/tutorial/query-params.md
📝 Docs preview for commit 314a2d1 at: https://649a13c8b14d050fee045fd7--fastapi.netlify.app |
Thanks for your contribution! @SnowSuno 🚀✨ And thanks for the help @NinaHwang 🤓 |
I found some translations that doesn't go well with the english docs.
ex)
But when you want to make a query parameter required, you can just not declare any default value:
그러나 쿼리 매개변수를 필수로 만들려면 기본값을 선언할 수 없습니다:
Which actually means:
그러나 쿼리 매개변수를 필수로 만들려면 단순히 기본값을 선언하지 않으면 됩니다:
I also smoothened some awkward translations to make it easier to understand.
Thank you always for your hard work.
related : #2017