Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Make sure a parameter defined as required is kept required in OpenAPI even if defined as optional in another dependency #4319

Merged
merged 8 commits into from
Sep 3, 2022
Merged

🐛 Make sure a parameter defined as required is kept required in OpenAPI even if defined as optional in another dependency #4319

merged 8 commits into from
Sep 3, 2022

Commits on Dec 21, 2021

  1. enforce once-required parameter

    @chardigio
    chardigio committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    ee88f8c View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. simpler logic

    @chardigio
    chardigio committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    3e9cf9d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. 🔀 Merge master

    @tiangolo
    tiangolo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    0f3ea96 View commit details
    Browse the repository at this point in the history

  2. ✅ Update test for same parameter required and optional in OpenAPI

    @tiangolo
    tiangolo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    9902a99 View commit details
    Browse the repository at this point in the history

  3. ♻️ Re-implement logic to detect required parameter definitions over n… 

    …on-required ones

taking into account recent changes to take into account location of parameter
    @tiangolo
    tiangolo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    bafa232 View commit details
    Browse the repository at this point in the history

  4. 👷 Trigger CI, Codecov is behaving 😭

    @tiangolo
    tiangolo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    d2e3ae3 View commit details
    Browse the repository at this point in the history

  5. ✅ Add missing test to fix coverage

    @tiangolo
    tiangolo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    3740d8d View commit details
    Browse the repository at this point in the history

  6. 💚 Try CI again, Codecov, would you please let me weekend at some point?

    @tiangolo
    tiangolo committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    230cdcc View commit details
    Browse the repository at this point in the history