Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default extra response #489

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Fix default extra response #489

merged 3 commits into from
Aug 30, 2019

Conversation

tiangolo
Copy link
Owner

Fix "default" extra response, when combined with responses with status codes and status code ranges.

Continuation of #435.

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #489 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #489   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         244    244           
  Lines        5707   5708    +1     
=====================================
+ Hits         5707   5708    +1
Impacted Files Coverage Δ
tests/test_additional_responses_router.py 100% <ø> (ø) ⬆️
fastapi/openapi/utils.py 100% <100%> (ø) ⬆️
fastapi/openapi/models.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32e800...848569b. Read the comment docs.

@tiangolo tiangolo merged commit 55c4b5f into master Aug 30, 2019
@tiangolo tiangolo deleted the fix-default-response branch August 30, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant