-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✏️ Fix typos in data for tests #4958
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4958 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 540 532 -8
Lines 13969 13672 -297
==========================================
- Hits 13969 13672 -297
☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 63efdc0 at: https://628faf69384877273be629ca--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look correct, but the branch the changes are in has errors running the tests when I check it out. So I can't give it a clean review.
@Ryandaydev it'd be great if you can list out the errors. I see the GitHub checks have passed for this PR. |
When I use gh checkout 4958, it looks at the ryanrussell/master branch. In that branch, it looks like the test-cov-html.sh file is an old version containing an argument that isn't in the main branch version. So I can't run the test coverage script to get a clean test run. Here is the error: |
@Ryandaydev I checked from local, it works fine.
Ensure you have installed all the dependencies needed.
Then run:
|
Thanks, the pip command resolved my issue. No objections now -- I'll mark it as approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change looks good. Tests ran successfully.
Great, thanks @ryanrussell! 🔍 🤓 And thanks for the reviews and comments everyone! ☕ |
No description provided.