Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/advanced/events.md #5087

Merged
merged 3 commits into from Apr 2, 2024

Conversation

pers0n4
Copy link
Sponsor Contributor

@pers0n4 pers0n4 commented Jun 28, 2022

Description

Translate docs/advanced/events.md for Korean

Related Issue

#2017

@github-actions
Copy link
Contributor

📝 Docs preview for commit df36571 at: https://62bb243d5979ec329e8eb89e--fastapi.netlify.app

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf73051) to head (1d63f8b).
Report is 1674 commits behind head on master.

❗ Current head 1d63f8b differs from pull request most recent head 9d562f7. Consider uploading reports for the commit 9d562f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #5087    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13672   -297     
==========================================
- Hits         13969     13672   -297     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1d63f8b at: https://62bd7b969d9d5171b5ea1671--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/ko/docs/advanced/events.md 🌐 Add Korean translation for docs/ko/docs/advanced/events.md Jul 14, 2022
@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations labels Jul 14, 2022
@github-actions github-actions bot mentioned this pull request Jul 14, 2022
joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo
Copy link
Owner

📝 Docs preview for commit 9d562f7 at: https://649a0ad75638650781126ac6--fastapi.netlify.app

@tiangolo
Copy link
Owner

tiangolo commented Mar 30, 2024

Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Korean translations, that way if they are approved by each other, I could merge them. 🤓

https://github.com/tiangolo/fastapi/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Alang-ko+label%3Aawaiting-review

@alejsdev alejsdev merged commit c964d04 into tiangolo:master Apr 2, 2024
32 checks passed
@alejsdev
Copy link
Collaborator

alejsdev commented Apr 2, 2024

Thanks for the contribution! @pers0n4 🚀 ✨

And thanks for the review @junah201 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants