Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in First Steps doc #511

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix: typo in First Steps doc #511

merged 1 commit into from
Oct 3, 2019

Conversation

IgnatovFedor
Copy link
Contributor

In first program example function returns{"message": "Hello World"} instead of {"hello": "world"} (see https://fastapi.tiangolo.com/tutorial/first-steps/).

@IgnatovFedor IgnatovFedor changed the title fix: typo in first steps doc fix: typo in First Steps doc Sep 6, 2019
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #511   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         251    251           
  Lines        5988   5988           
=====================================
  Hits         5988   5988

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580cf8f...bdc26e1. Read the comment docs.

@alimcmaster1
Copy link

This isn’t a typo? It’s just a JSON example of the response body.

@IgnatovFedor
Copy link
Contributor Author

This isn’t a typo? It’s just a JSON example of the response body.

@alimcmaster1 an example of simplest FastAPI server is shown in documentation and below is not some JSON example of the response body but expected response of this server.

@alimcmaster1
Copy link

Ahh yes you are correct - didn’t see the top of the example. This LGTM - @tiangolo

@tiangolo tiangolo merged commit d5d9a20 into fastapi:master Oct 3, 2019
@tiangolo
Copy link
Member

tiangolo commented Oct 3, 2019

Oops! 😅 Thanks @IgnatovFedor ! 🎉 🍰 Good catch! 🕵️‍♂️ 🔍 🐛 📝

And thanks @alimcmaster1 for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants