Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix words in docs #514

Merged
merged 1 commit into from
Oct 4, 2019
Merged

fix words in docs #514

merged 1 commit into from
Oct 4, 2019

Conversation

prostomarkeloff
Copy link
Contributor

this really good fix :D

@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #514    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files         251    251            
  Lines        5988   5887   -101     
======================================
- Hits         5988   5887   -101
Impacted Files Coverage Δ
...est_additional_responses_custom_validationerror.py 100% <0%> (ø) ⬆️
docs/src/app_testing/tutorial003.py 100% <0%> (ø) ⬆️
...t_query_params_str_validations/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_custom_swagger_ui_redirect.py 100% <0%> (ø) ⬆️
docs/src/first_steps/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_additional_responses_router.py 100% <0%> (ø) ⬆️
docs/src/application_configuration/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_duplicate_models_openapi.py 100% <0%> (ø) ⬆️
tests/test_serialize_response_dataclass.py 100% <0%> (ø) ⬆️
...test_tutorial/test_path_params/test_tutorial005.py 100% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580cf8f...1218ea5. Read the comment docs.

@alimcmaster1
Copy link

LGTM

@tiangolo tiangolo merged commit 0761f11 into fastapi:master Oct 4, 2019
@tiangolo
Copy link
Member

tiangolo commented Oct 4, 2019

Oops, that's right. ✏️ 🔍 🕵️‍♂️ Thanks for your contribution @prostomarkeloff ! 🎉 🍰

And thanks @alimcmaster1 for the review!

@prostomarkeloff prostomarkeloff deleted the patch-1 branch October 4, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants