Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Quote pip install command for Zsh compatibility in multiple languages #5214

Conversation

nibuno
Copy link
Contributor

@nibuno nibuno commented Jul 31, 2022

I am a first time contribute.
Sorry for any errors.

before not use quotes
failed
$ pip install fastapi[all]
$ pip install uvicorn[standard]
zsh: no matches found: fastapi[all]

after use quotes
success
$ pip install "fastapi[all]"
$ pip install "uvicorn[standard]"

relevance?
#3925
#3131

@nibuno nibuno changed the title quote pip install command for zsh compatibility for quote pip install command for zsh compatibility for japanese etc Jul 31, 2022
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #5214 (96910bf) into master (f79e6a4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13684     13684           
=========================================
  Hits         13684     13684           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9384d29 at: https://62e66c5fb929a74a38ef0524--fastapi.netlify.app

@tiangolo tiangolo changed the title quote pip install command for zsh compatibility for japanese etc 📝 Quote pip install command for Zsh compatibility in multiple languages Aug 18, 2022
@tiangolo tiangolo enabled auto-merge (squash) August 18, 2022 16:13
@tiangolo
Copy link
Member

Awesome, thank you @Yumihiki! 🙇 🚀

@tiangolo tiangolo merged commit 38802ee into fastapi:master Aug 18, 2022
@nibuno
Copy link
Contributor Author

nibuno commented Aug 18, 2022

@tiangolo Thanks for the great framework too!
And thanks for the title fix!🙇

JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
…ages (fastapi#5214)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants