Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the ability to set any route class when adding a third-party router #5273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ilyaTT
Copy link

@ilyaTT ilyaTT commented Aug 16, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (31f8757) compared to base (cf73051).
Patch has no changes to coverable lines.

❗ Current head 31f8757 differs from pull request most recent head 3e11ae6. Consider uploading reports for the commit 3e11ae6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #5273    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13684   -285     
==========================================
- Hits         13969     13684   -285     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <ø> (ø)
tests/main.py 100.00% <0.00%> (ø)
tests/utils.py 100.00% <0.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
tests/test_query.py 100.00% <0.00%> (ø)
fastapi/websockets.py 100.00% <0.00%> (ø)
fastapi/concurrency.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 31f8757 at: https://62fba191bc6e9e31ddc8dfd8--fastapi.netlify.app

@iudeen
Copy link
Contributor

iudeen commented Aug 16, 2022

Any context on why this is needed and what would be the impact?

@ilyaTT
Copy link
Author

ilyaTT commented Aug 17, 2022

Any context on why this is needed and what would be the impact?

The routing of our project has a nested structure.
At the lower level, a router with an overridden __init__ was used. However, when importing, we need to use a different route class.
Because everywhere in the project it is possible to pass the route_class_override parameter, then it would be right to allow it here as well.

@tiangolo tiangolo added the feature New feature or request label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants