🌐 🔠 📄 🐢 Translate docs to Emoji 🥳 🎉 💥 🤯 🤯 #5385
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5385 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13951 -18
=========================================
- Hits 13969 13951 -18 see 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
📝 Docs preview for commit 5590e38 at: https://6320bdb2dc53d17efc1ba804--fastapi.netlify.app |
docs/emj/docs/features.md
Outdated
| * <a href="https://github.com/OAI/OpenAPI-Specification" class="external-link" target="_blank"><strong>OpenAPI</strong></a> 🏗 API, ✅ 🙂📛 <abbr title="💭 HTTP-👩🔬 ✅ : POST, GET, PUT, DELETE">🛠</abbr> <abbr title="💭: 🔗, 🛣, '🍵', ♒️.">🌌</abbr>, 🔢, ✔ 💪, 💂♂, ♒️. | ||
|
|
There was a problem hiding this comment.
I think "Security" in native emoji is more like "👮" than your translated "💂♂". However, the other parts are perfect, I like it
There was a problem hiding this comment.
I find amusing the seriousness of this review. 😂
There was a problem hiding this comment.
It looks👀 like the markup📝 is a bit🤏 broken💔, making it hard😅 to read📖 such great👍 documentation📝.
https://6320bdb2dc53d17efc1ba804--fastapi.netlify.app/emj/
|
📝 Docs preview for commit 3b37ad3 at: https://6321d213a4b3527ed976768f--fastapi.netlify.app |
|
@FeeeeK 🔥🔥🔥 Fixed 🔥🔥🔥 |
|
Hey there! Is this coming from a joke or something somewhere else? 😅 I imagine that given all the approvals and interactions, but I didn't see the original joke... 🤷 |
Great💫, I think this is a very nice👍 change, making the documentation📝 much friendlier🙌. It's a pity that the previous⏮️ version of the |
|
Really 😃😃😃 cool 😍😍🙂 idea 👍🧠🫦 bro 🥵😎🥵!!! |
|
@tiangolo You see right through us. Forgive us this joke. We're just really sad about the decision to remove the emojis in #3273. They made the documentation unusual and stand out from the documentation of other frameworks. That's why we wanted to bring back that distinctive feature, so we'd be very happy if you could merge this pull request.❤️ |
|
I think I could do a full translation of all the pages as well as fix a few formatting issues if you would ever consider adding an emoji version of the documentation, just for fun 😊 |
|
Cool! 🥳 I'm going to finish up translating the remaining pages and prepare this for merging as promised. 😄 |
|
📝 Docs preview for commit d51f60e at: https://64090307112b5b1b116dc96e--fastapi.netlify.app |
|
LGTM |
|
@LeeeeT, I tried to send a review, but for some reason github just gives an error, I have already contacted support, I hope they will help, but for now please wait a bit. |
|
Well, @FeeeeK, you can submit a pull request with your proposed changes to my fork 😋 |
|
📝 Docs preview for commit 24527b5 at: https://642663a0b548622487cc93a0--fastapi.netlify.app |
|
📝 Docs preview for commit d51f60e at: https://6426a87c996bf600a71bb68f--fastapi.netlify.app |
|
Now I know that github doesn't like this |
|
📝 Docs preview for commit 924c274 at: https://6426a9b35d5fc100b1db0463--fastapi.netlify.app |
|
@FeeeeK It's probably for the best... 😐 |
|
📝 Docs preview for commit 7b50132 at: https://6427f6b2a6d5896aca012137--fastapi.netlify.app |
There was a problem hiding this comment.
I'm actually impressed. You did an amazing job here. The consistency of the translation from the original is great. 🤓😎
I moved the content from emj toem, that simplifies the URLs and makes using the internal scripts simpler (to run the docs live locally, etc).
em is not assigned to any other language so that's fine. https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes#Table_of_all_possible_two_letter_codes
I imagine you automatized parts of it, I would love to know how you did it!
I'm also cracking up. 😂
Thank you for your contribution! 🙇🍰
@tiangolo For all this, regexes were used to separate the text from code blocks, and then the translation through Yandex translator (link), and after all this, I fixed some inaccuracies and broken emojis. I think this can also be automated and converted to GitHub action, but we need to make it a little more stable. |
|
Yea, it required some reverse engineering and use of private API in order to automate translating with Yandex. 😅 And my script for extracting readable and translatable text from Anyway, I want to thank all the participants of this pull request. ❤️ You guys made the prank even funnier. 🤪🥰 |
I just really love 💕 🤩 the idea of adding some emojis 😄😁😅 here and there across the 📄 docs 📄 (like in here for example). So I decided to write ✍ the entire documentation out of emojis 💥🎉🌟. All these words 🤮🤢 and... fancy-looking letters.. 👎👎👎 ugh... That's so boring 🥱. I believe reading documentation made of emojis will definitely (don't argue 😛🤪) be much funnier 😃 and easier 😻 for beginners. Just take a look at a new awesome 🔥 async page 🔥. So here it is, don't thank me. 💥💯💫⭐