-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✏️ Update highlighted line in docs/en/docs/tutorial/bigger-applications.md
#5490
Conversation
📝 Docs preview for commit f598e52 at: https://63473fe4aeb3b90fd9daa586--fastapi.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5490 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13934 -35
=========================================
- Hits 13969 13934 -35 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 3dec641 at: https://639cdfc9e97dd30578989db8--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@papb If I am reading the tutorial correctly, the existing doco incorrectly highlights row 4.
I think instead of this change (which highlights lines 4 & 5), I think it should be changed to highlight row 5.
@Ryandaydev Thank you, you're right. After re-reading I decided to also change another block to highlight one extra line, can you take a look? |
📝 Docs preview for commit e3b590b at: https://63a3ee1a51a71e488d9d9ea1--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes have been applied.
How can I help this PR move forward? |
docs/en/docs/tutorial/bigger-applications.md
Good catch. Thanks @papb 🙂 And thanks for the review @iudeen and @Ryandaydev ✌️ |
No description provided.