Add supporting for async callable object #5506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5506 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13967 -2
=========================================
- Hits 13969 13967 -2 ☔ View full report in Codecov by Sentry. |
|
📝 Docs preview for commit 3d0072e at: https://634d4461e3a2ec1d01feb169--fastapi.netlify.app |
sviat9440
changed the title
yezz123
approved these changes
Oct 18, 2022
|
What are the next steps? |
Kludex
reviewed
Oct 19, 2022
Comment on lines
+266
to
+272
| def is_coroutine_function(obj: Any) -> bool: | ||
| while isinstance(obj, functools.partial): | ||
| obj = obj.func | ||
|
|
||
| return asyncio.iscoroutinefunction(obj) or ( | ||
| callable(obj) and asyncio.iscoroutinefunction(obj.__call__) | ||
| ) |
There was a problem hiding this comment.
|
The next step is to wait for Sebastián to review it. 🙏 |
iudeen
approved these changes
Oct 27, 2022
|
... |
|
Is the project dead? |
|
Nop. |
|
I'll review tomorrow. |
Kludex
requested changes
Jul 18, 2023
Comment on lines
+266
to
+272
| def is_coroutine_function(obj: Any) -> bool: | ||
| while isinstance(obj, functools.partial): | ||
| obj = obj.func | ||
|
|
||
| return asyncio.iscoroutinefunction(obj) or ( | ||
| callable(obj) and asyncio.iscoroutinefunction(obj.__call__) | ||
| ) |
alejsdev
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.