Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Update Help FastAPI: Help Maintain FastAPI #5632

Merged
merged 1 commit into from Nov 13, 2022
Merged

Conversation

tiangolo
Copy link
Owner

馃摑 Update Help FastAPI: Help Maintain FastAPI

@iudeen
Copy link
Contributor

iudeen commented Nov 13, 2022

Yay! Much needed guideline! Hope the community follows and benefits for a collective and collaborative benefit!鉂わ笍

@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request November 13, 2022 19:29 Inactive
@github-actions
Copy link
Contributor

馃摑 Docs preview for commit 81c867c at: https://637145a33de31a02a6d37dfe--fastapi.netlify.app

@tiangolo tiangolo merged commit 50ea75a into master Nov 13, 2022
10 checks passed
@tiangolo tiangolo deleted the help-fastapi branch November 13, 2022 19:34
@tiangolo
Copy link
Owner Author

Thanks @iudeen! And thanks for all the help here! 馃檱

Copy link
Contributor

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, feel free to skip if it鈥檚 not making sense.


### Ask to close

If they reply, there's a high chance you will have solved their problem, congrats, **you're a hero**! 馃Ω
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If they reply, there's a high chance you will have solved their problem, congrats, **you're a hero**! 馃Ω
If they reply, there's a high chance you would have solved their problem, congrats, **you're a hero**! 馃Ω


You can help me review pull requests from others.

Again, please try as best to be kind. 馃
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Again, please try as best to be kind. 馃
Again, please try your best to be kind. 馃

Felt it sounds better 馃槃


### Understand the problem

* First, make sure you **understand the problem** that the pull request is trying to solve. It might have a longer discussion in an issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* First, make sure you **understand the problem** that the pull request is trying to solve. It might have a longer discussion in an issue.
* First, make sure you **understand the problem** that the pull request is trying to solve. It might have a detailed discussion in an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants