Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade and relax dependencies for extras "all" #5634

Merged
merged 1 commit into from Nov 13, 2022

Conversation

tiangolo
Copy link
Owner

⬆️ Upgrade and relax dependencies for extras "all"

Because @ofek convinced me with this link: https://iscinumpy.dev/post/bound-version-constraints/ ( by @henryiii)

@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request November 13, 2022 20:45 Inactive
@github-actions
Copy link
Contributor

📝 Docs preview for commit 89e4cb1 at: https://637157c67a360d0ece9f8db3--fastapi.netlify.app

@tiangolo tiangolo merged commit 89095eb into master Nov 13, 2022
10 checks passed
@tiangolo tiangolo deleted the upgrade-relax-extras-all branch November 13, 2022 20:50
@sallner
Copy link

sallner commented Nov 14, 2022

Thanks for relaxing some of the restrictions. May I ask, what convinced you to keep the other optional dependencies restricted in the old way? I can understand that you keep pydantic and starlette restricted, but now we have pyyaml some times with upper bounds and once without.

@musicinmybrain
Copy link

As the primary maintainer of the python-fastapi package in Fedora Linux, I appreciate this change. It really helps to be able to tell the difference between known incompatibilities that I need to try to work around and arbitrary restrictions that I can simply ignore.

@tiangolo
Copy link
Owner Author

Thanks for the feedback! I'm glad this was well received 😅

@sallner I didn't uncap the other extras because those shouldn't really be extras, they are development dependencies, for tests, docs, and local development. I should not have them exposed in the released versions/wheels.

I plan on removing those extras that shouldn't be public and replace them with something else, probably requirements.txt files with pinned dependencies that Dependabot can suggest to update later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants