Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/ko/docs/deployment/docker.md #5657

Merged
merged 7 commits into from Jan 22, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/deployment/docker.md #5657

merged 7 commits into from Jan 22, 2024

Conversation

nearnear
Copy link
Contributor

@nearnear nearnear commented Nov 18, 2022 •
edited

@github-actions
Copy link
Contributor

📝 Docs preview for commit f8ca8fe at: https://637739a424e44b09b52602fe--fastapi.netlify.app

@nearnear nearnear changed the title Add Korean translation for docs/ko/docs/development/docker.md Add Korean translation for docs/ko/docs/deployment/docker.md Nov 18, 2022
@nearnear nearnear changed the title Add Korean translation for docs/ko/docs/deployment/docker.md Add Korean translation for docs/ko/docs/deployment/docker.md Nov 18, 2022
@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations labels Nov 20, 2022
@github-actions github-actions bot mentioned this pull request Nov 20, 2022
Closed
@joonas-yoon
Copy link
Contributor

first, thanks for your work!

and I think you'd like to remove the files .DS_Store

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8696ec7 at: https://63806b2f8cebdf53a09a34c5--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 03b076f at: https://638075e6573709586517659b--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit c34e03d at: https://6380778257370957b51770a8--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit d774101 at: https://638078ce319a3959cf2f3090--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 03e768f at: https://638079eba69c5562106564b4--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit c1f77ba at: https://638366886260b070dc36f1fe--fastapi.netlify.app

PraveenNanda124
PraveenNanda124 reviewed Dec 8, 2022
View reviewed changes
Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9f940bb at: https://639ce4b804318b049f824123--fastapi.netlify.app

joonas-yoon
joonas-yoon approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@joonas-yoon joonas-yoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Dec 17, 2022
@joonas-yoon
translated by tiangolo#5657
3c6ac37
@tiangolo tiangolo changed the title Add Korean translation for docs/ko/docs/deployment/docker.md 🌐 Add Korean translation for docs/ko/docs/deployment/docker.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit ca726ee at: https://649a1bae7ba2251554e3ac0b--fastapi.netlify.app

@alejsdev
Copy link
Collaborator

Thank you! @nearnear 😃

And thanks for the reviews @joonas-yoon and @PraveenNanda124 🚀

@alejsdev alejsdev merged commit 6c3d8eb into tiangolo:master Jan 22, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenNanda124 PraveenNanda124 PraveenNanda124 left review comments

@joonas-yoon joonas-yoon joonas-yoon approved these changes

Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nearnear @joonas-yoon @tiangolo @alejsdev @PraveenNanda124